Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Apr 2020 10:19:17 +0100
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     Oscar Carter <oscar.carter@gmx.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        Amir Mahdi Ghorbanian <indigoomega021@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use defines in vnt_mac_reg_bits_*
 functions
Message-ID: <20200402091917.GA17323@jiffies>
References: <20200328095433.7879-1-oscar.carter@gmx.com>
 <20200331102906.GA2066@kadam>
 <20200401165537.GC3109@ubuntu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200401165537.GC3109@ubuntu>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jiffies (5.151.93.48) by LO2P265CA0096.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Thu, 2 Apr 2020 09:19:18 +0000
X-Originating-IP: [5.151.93.48]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7f4ccc0e-44bc-4600-4602-08d7d6e6ec3f
X-MS-TrafficTypeDiagnostic: DBBSPR01MB0006:
X-Microsoft-Antispam-PRVS: <DBBSPR01MB0006C60F282FB5729B2E3F1CB3C60@DBBSPR01MB0006.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 0361212EA8
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4491.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(346002)(39830400003)(396003)(366004)(136003)(376002)(8936002)(81156014)(6916009)(4326008)(55016002)(66476007)(44832011)(9576002)(1076003)(5660300002)(33656002)(66946007)(9686003)(66556008)(7416002)(86362001)(26005)(8676002)(52116002)(2906002)(54906003)(81166006)(33716001)(508600001)(956004)(16526019)(6496006)(186003)(316002)(53546011)(518174003);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: n4u0K6O63BDc/gC9mbx2arKxvK3uUoizy1LQR+NT+Uo4zlv3g1cI1HdXCjE1VQsEIvNHe/kr7Nt6zu+fCd2SzFVnP4HBa5X1zIwG2mrD2wYGvTuE/7wZ9q22QYpJpDZFIJwzbP0VVREYOAnkrM5w7Hq1vjvX/b8PUM04RilJwoogPyUCcqsDcqNOq7+FoBD0wZn3UO5y/yARTxJW8XlZVemNibBk/9WLtxnOjtcF6hxNeMY+FEviK4WDBvjyKmroZZt18psZEcd7dhzH+PidRFf9Our0Be7sb57xiPVeL9LZsoiWOpUhKih98U9GGSTCrZp1/3iSDEyqB6pfomIf7+FnNQnBD8E9r3eJtoHv+EzxSUUbC+PrE+KWP4LeE4K0NfybnOaBvSf/nuGclTHZiOAynsMPeETdm4BuQSHV+Fg2C8UrdjYcH5L1gygGwECa8fOXMKipdG2kYVpzYZ4xpWSQBMWoqy4hu/eB5+M406JYeXii7lunD+/xwoprH6BM
X-MS-Exchange-AntiSpam-MessageData: wNe6RYRJg9FZFDEDU3m4Uw3Bgneik9mZ18cQMwragI0OLyi6llxaGkatlyrNrxxtE82fhuaA1HZ3G6L+pq7EMo0YRKKZ+Hbfe/jlsVnJKfS4cDPZCHgz7Ghj9MpTuTzwv/khEjDeMni8Tidpo+xWFg==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4ccc0e-44bc-4600-4602-08d7d6e6ec3f
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2020 09:19:19.4294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgxYo4Z0cVdgBPZl1NOvyJjYc8TcLeXALWTXZ/7g0YDGRjkBvb8jMCV6Uj151Ou353DduwXBix/8gic9VwM1OPX3O5grZks+t4+e8Ms8YEw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBSPR01MB0006
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/01/20 18:55:38, Oscar Carter wrote:
> On Tue, Mar 31, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> > On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote:
> > > Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0
> > > registers to can use them in the calls to vnt_mac_reg_bits_on and
> > > vnt_mac_reg_bits_off functions. In this way, avoid the use of BIT()
> > > macros and clarify the code.
> > >
> > > Fixes: 3017e587e368 ("staging: vt6656: Use BIT() macro in vnt_mac_reg_bits_* functions")
> > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> > > ---
> > >  drivers/staging/vt6656/baseband.c |  6 ++++--
> > >  drivers/staging/vt6656/card.c     |  3 +--
> > >  drivers/staging/vt6656/mac.h      | 12 ++++++++++++
> > >  drivers/staging/vt6656/main_usb.c |  2 +-
> > >  4 files changed, 18 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> > > index a19a563d8bcc..dd3c3bf5e8b5 100644
> > > --- a/drivers/staging/vt6656/baseband.c
> > > +++ b/drivers/staging/vt6656/baseband.c
> > > @@ -442,7 +442,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
> > >  		if (ret)
> > >  			goto end;
> > >
> > > -		ret = vnt_mac_reg_bits_on(priv, MAC_REG_PAPEDELAY, BIT(0));
> > > +		ret = vnt_mac_reg_bits_on(priv, MAC_REG_PAPEDELAY,
> > > +					  PAPEDELAY_B0);
> >
> > This doesn't clarify anything.  It makes it less clear because someone
> > would assume B0 means something but it's just hiding a magic number
> > behind a meaningless define.  B0 means BIT(0) which means nothing.  So
> > now we have to jump through two hoops to find out that we don't know
> > anything.
> >
> I created this names due to the lack of information about the hardware. I
> searched but I did not find anything.
> 
> > Just leave it as-is.  Same for the rest.
> Ok.
> 
> >
> > There problem is a hardware spec which explains what this stuff is.
> >
> It's possible to find a datasheet of this hardware to make this modification
> accordingly to the correct bit names of registers ?

I haven't found any so far, if your researches are luckier than mine, I
would be interested too. Even getting your hands on the actual device is
complicated.

Thanks,
Quentin