Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1543413ybb; Thu, 2 Apr 2020 02:52:49 -0700 (PDT) X-Google-Smtp-Source: APiQypIB94rfXRNjgCA6vFglWhTPCaNOaMRBmbNQdGwvZKVzaA49MizL+fJDX85zsVrHT+d8ryQU X-Received: by 2002:a4a:250b:: with SMTP id g11mr2012780ooa.27.1585821169148; Thu, 02 Apr 2020 02:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585821169; cv=none; d=google.com; s=arc-20160816; b=uZCMylyYhd6Trpzds6yQdbifaUI4+FrTsSRQUP4Xg0EwZTY1XMgB/y4/jjUnVBDjxb 6Ry5SvWXWUXKGnnnppXmm4hmOIKeysifGucqM19gsRhy1I/aCkonYG9Xxc7MoYkRFEmB UhScqzrfC1uZmQUXBqm1C1K/l1xIcoaIn0HuEDcC0P8ycFIhcd6/PPeIuHUeUBkwDbUu k946yagoYw/d0v/N1nfxFbJWss6hkvhGd+4Er4IANeG1RQCD8ij9WTQVFC+hQv4Ybz5+ mCHu2skNvkXOiFyBFqHr7bPvhL0d5GMbiyc2+5KCmUX2OHOjE6mpMX8rnEhvZUxNPB5o RxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QBLTad+iICgypznQbxOsc5K7y6BcjDBR3loOYsj8SjI=; b=mGIE6+ASiYKv1f2qqHTuHtzhcS4WC/7LZ0SNMP/K0Nynrt0wy0KyDLvH/X5AyQcKBX q6pVOHIz27ewqjb4piu10O79VC6aU3yC+9hfTv5lyfVHHEZkRcBFaGMgdI9BNDiAfKYA MaUv0TqkGJ8N/Ly0Hd8zBUQKcVzMmCsBALUIDuwxyLt1wm/OLWUb3oCDVPZwVqYatrEk nHbYRKx++cV/AHQr//8l83Jnz00SzqXBOijpSvOAlCo7A3wU6scB0ez6Jb3ZU8APRcdy M1egQdrHPAlMe0lYQJvHpdWsAPZQfs5FFMkxTPdvYuKXsogph48yiGd9AWeULzjKR2bg XjjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ozs9wvGW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si2020432oot.35.2020.04.02.02.52.31; Thu, 02 Apr 2020 02:52:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ozs9wvGW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387476AbgDBJY2 (ORCPT + 99 others); Thu, 2 Apr 2020 05:24:28 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53811 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgDBJY2 (ORCPT ); Thu, 2 Apr 2020 05:24:28 -0400 Received: by mail-wm1-f67.google.com with SMTP id d77so2604307wmd.3 for ; Thu, 02 Apr 2020 02:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QBLTad+iICgypznQbxOsc5K7y6BcjDBR3loOYsj8SjI=; b=Ozs9wvGWhInw+jHbV+TIbhn0mHoMFHCEFO25FeTvEMCTPyY7OHacXfEcXTiNoiBAeQ 1VC8fPDraFaL2tn2VMqFbzjR1t79IdHS47FEvt89UccYOkek8UikchvvcScI+YAjAs3/ TE8T3z8N4aqHw3WD5KZR9MWiTu/hQbk1lodhGs9xJG5gBFJa61Vrvi0K7VDctd344t/N /jNl1HvBSa9zNSpEP8Trto2aUS9cIST5YLl/mwd5+LO0lomPjvAW9JdePTMIqtmHn82N lN9l20L2TlPcVG4dnFhtolx0+Ct2YljEiGF98iw/XLHqCdoCP7NhtERc1Kweco00bYgX /fiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QBLTad+iICgypznQbxOsc5K7y6BcjDBR3loOYsj8SjI=; b=mwMHAS7Ki9ALRn8DqiR1Y3+hAznHGp+zP9KeDB3nZggNVWSCA1+saJM3tEZ0ydvcXR rtdeDoO0LGuwKMX9TFtWew4IK3iBUlxaXxlS+rDXC+9PIQHnOwyBu2Eo+UjJyx3fSWu6 GgtshsmSfiE03ywV9+BtfxWWehTnwAqIL4UTp6AdkKMnoZX0Y5qumKJ+r3YindBNLa7P RRp9/Ph1Asz7VP6NDo2jR5VCZNT95MqMKw2eb7Tz/X/nTeBrNA6Maht1uQ2keckhQPlN lVFNNf0qILVAelIAaWxOQd0WVICMWJq4F01xEzuOzBw2rGOh4DHEN7GH0GZX9z2z92nA OMSQ== X-Gm-Message-State: AGi0PuZa7OfRxdC7d1IskGZx0jC5kDxgx4yXeI7m3dwi5PjiNMVS98bj ye2aEQMm18tczi3n7iyezYQK0w== X-Received: by 2002:a7b:cde8:: with SMTP id p8mr2493598wmj.87.1585819466713; Thu, 02 Apr 2020 02:24:26 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:6097:1406:6470:33b5]) by smtp.gmail.com with ESMTPSA id f13sm6396383wrx.56.2020.04.02.02.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 02:24:26 -0700 (PDT) Date: Thu, 2 Apr 2020 11:24:17 +0200 From: Jean-Philippe Brucker To: Bharat Bhushan Cc: Robin Murphy , "joro@8bytes.org" , "mst@redhat.com" , "jasowang@redhat.com" , "virtualization@lists.linux-foundation.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "eric.auger.pro@gmail.com" , "eric.auger@redhat.com" Subject: Re: [EXT] Re: [RFC PATCH v2] iommu/virtio: Use page size bitmap supported by endpoint Message-ID: <20200402092417.GA1176452@myrica> References: <20200401113804.21616-1-bbhushan2@marvell.com> <20200401154932.GA1124215@myrica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2020 at 03:53:40AM +0000, Bharat Bhushan wrote: > > > > +struct virtio_iommu_probe_pgsize_mask { > > > > + struct virtio_iommu_probe_property head; > > > > + __u8 reserved[4]; > > > > + __u64 pgsize_bitmap; > > > > Should be __le64 > > Based on" iommu/virtio: Fix sparse warning" patch https://www.spinics.net/lists/linux-virtualization/msg41944.html changed to __u64 (not __le64) Yes that one was only for the virtio config struct, to play nice with other devices. We should still use __le for the other structures, including probe properties. Thanks, Jean > > Will keep __le64. > > Thanks > -Bharat > > > > > Thanks, > > Jean > > > > > > +}; > > > > + > > > > #define VIRTIO_IOMMU_RESV_MEM_T_RESERVED 0 > > > > #define VIRTIO_IOMMU_RESV_MEM_T_MSI 1 > > > >