Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1585192411-25593-1-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1585192411-25593-1-git-send-email-Anson.Huang@nxp.com>
From:   Amit Kucheria <amit.kucheria@verdurent.com>
Date:   Thu, 2 Apr 2020 16:14:05 +0530
Message-ID: <CAHLCerOZvYT71gcZd7_NpWKon6LSH9kcA1UK1objTc9aK4nOvA@mail.gmail.com>
Subject: Re: [PATCH] thermal: imx_sc_thermal: Add hwmon support
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, kernel@pengutronix.de,
        Fabio Estevam <festevam@gmail.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        lakml <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, Linux-imx@nxp.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 26, 2020 at 8:50 AM Anson Huang <Anson.Huang@nxp.com> wrote:
>
> Expose i.MX SC thermal sensors as HWMON devices.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  drivers/thermal/imx_sc_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index a8723b1..b2b68c9 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -14,6 +14,7 @@
>  #include <linux/thermal.h>
>
>  #include "thermal_core.h"
> +#include "thermal_hwmon.h"
>
>  #define IMX_SC_MISC_FUNC_GET_TEMP      13
>
> @@ -115,6 +116,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>                         ret = PTR_ERR(sensor->tzd);
>                         break;
>                 }
> +
> +               if (devm_thermal_add_hwmon_sysfs(sensor->tzd))
> +                       dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n");
>         }
>
>         of_node_put(sensor_np);
> --
> 2.7.4
>