Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964804AbWBXXxl (ORCPT ); Fri, 24 Feb 2006 18:53:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964805AbWBXXxl (ORCPT ); Fri, 24 Feb 2006 18:53:41 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:9665 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S964804AbWBXXxk (ORCPT ); Fri, 24 Feb 2006 18:53:40 -0500 Date: Sat, 25 Feb 2006 00:53:21 +0100 From: Pavel Machek To: Nigel Cunningham Cc: "Rafael J. Wysocki" , Dmitry Torokhov , Andreas Happe , linux-kernel@vger.kernel.org, Suspend2 Devel List Subject: Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.) Message-ID: <20060224235321.GA1930@elf.ucw.cz> References: <20060201113710.6320.68289.stgit@localhost.localdomain> <20060224131206.GB1717@elf.ucw.cz> <200602242122.53763.rjw@sisk.pl> <200602250911.54850.ncunningham@cyclades.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602250911.54850.ncunningham@cyclades.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 28 Hi! > > > 2) shrink_all_memory() should be fixed. It should not really return if > > > there are more pages freeable. > > > > Well, that would be a long-run solution. However, until it's fixed we can > > use a workaround IMHO. ;-) > > Isn't trying to free as much memory as you can the wrong solution anyway? I > mean, that only means that the poor system has more pages to fault back in at > resume time, before the user can even begin to think about doing anything > useful. You might be able to say "Every machine that suspend2 works on, > swsusp works on", but the later will be a pretty sad definition of works! We are trying to catch a bug here. suspend2 or not, it is a bug and it should be fixed (or at least understood). [Also please try to tone down your messages. Your suspend2 may be more user-friendly, you do not want to start that flamewar again, do you? Saying "don't bother fixing that" is not nice thing to do.] Pavel -- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/