Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Apr 2020 14:30:02 +0200
From:   Robert Richter <rrichter@marvell.com>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
CC:     <thor.thayer@linux.intel.com>, <bp@alien8.de>,
        <mchehab@kernel.org>, <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC/altera:Use platform_get_irq_optional()
Message-ID: <20200402123001.obgzqmlure4cfvh7@rric.localdomain>
References: <20200402112740.15580-1-tangbin@cmss.chinamobile.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200402112740.15580-1-tangbin@cmss.chinamobile.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR05CA0192.eurprd05.prod.outlook.com (2603:10a6:3:f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Thu, 2 Apr 2020 12:30:09 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 479888b1-33c6-4a02-5a5d-08d7d7019652
X-MS-TrafficTypeDiagnostic: BYAPR18MB2485:
X-Microsoft-Antispam-PRVS: <BYAPR18MB24857D685875FD4F8C23421CD9C60@BYAPR18MB2485.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:660;
X-Forefront-PRVS: 0361212EA8
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR18MB2661.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(16526019)(81166006)(1076003)(86362001)(66946007)(66556008)(66476007)(6666004)(9686003)(478600001)(81156014)(55016002)(5660300002)(8676002)(316002)(2906002)(26005)(186003)(7696005)(956004)(52116002)(8936002)(6916009)(53546011)(6506007)(4326008);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o39WEXSMvx6BKat03knhyDw2TcrgMEAAjto5IQVOxyQXVqfBG/G8DS9MzgGa76NOzYve2sIiCHO1CLVGgqS18JUFzmQjLs9bDvr9tYGJjAWPGOr/wwOLNUtSs0lrdUfcnNz1lITwsypK75iKffLBV1jFpeFWehTjz0UjMWcPbgcY60764HdyJs/aHywyWujlCDEa6wVTK/EJHXmEyjGWAzBmUhvOIQIFRF6XQN5oHD4287Hb0YnTsAJmXm7yiMX8mTl5DayYednvjeWJ+EJdc8+k/D9Vwo47BvVEZXaBLU5ij3jVq8/VD4kX7O9cMWPC8U9M8vsDMlXbeBiqzHa8Xyea/d8FIz6Er3PcDZFQLu8V2HlLDe7V5eKO42PLtJv42vaFOuciCsxQFC6yy9t4bQkxV+hupuA51C9eMAYvO2PR5GklRnZG32GvBqYiqLkv
X-MS-Exchange-AntiSpam-MessageData: hzzIi2uRmeXLqwEk5Hxu1nzTzBk4hyfMWBRvQJD4Lj8TRaIpKuFROSPADwbcW+YPxtY12dS8Y9OrQAeUVihMXgsMkqtQW+e8v1SluM85Tysg0JmM0xyeCtap2u75y5CkGf0l/3WNCeJp/R1A6d8Klw==
X-MS-Exchange-CrossTenant-Network-Message-Id: 479888b1-33c6-4a02-5a5d-08d7d7019652
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2020 12:30:11.6900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UTvlZDf3vJKwN40CJq96DsI+S3uVN3am/MpXgY1PNtK9OPfJWuL+PTNteO/IMWth2Evd7BTw96S+aO6U9WWy/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2485
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-02_04:2020-03-31,2020-04-02 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02.04.20 19:27:40, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.

I don't see a difference other than hiding a -EPROBE_DEFER error
message. If that is your intention, please update subject and
description accordingly.

Thanks,

-Robert

> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/edac/altera_edac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index e91cf1147..e12bad148 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -2099,7 +2099,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>  
> -	edac->sb_irq = platform_get_irq(pdev, 0);
> +	edac->sb_irq = platform_get_irq_optional(pdev, 0);
>  	if (edac->sb_irq < 0) {
>  		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
>  		return edac->sb_irq;
> @@ -2134,7 +2134,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  		}
>  	}
>  #else
> -	edac->db_irq = platform_get_irq(pdev, 1);
> +	edac->db_irq = platform_get_irq_optional(pdev, 1);
>  	if (edac->db_irq < 0) {
>  		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
>  		return edac->db_irq;
> -- 
> 2.20.1.windows.1
> 
> 
>