Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] selftests: kvm: Add mem_slot_test test
To:     Andrew Jones <drjones@redhat.com>
Cc:     kvm@vger.kernel.org, pbonzini@redhat.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        david@redhat.com
References: <20200330204310.21736-1-wainersm@redhat.com>
 <20200330204310.21736-3-wainersm@redhat.com>
 <20200331081632.ithcwuzjyjhiwphy@kamzik.brq.redhat.com>
 <b261aa4f-87d5-2ac8-9f66-9f10e1a0803a@redhat.com>
 <20200401063817.gb5f4ah45qvtqkhw@kamzik.brq.redhat.com>
From:   Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-ID: <fef1fa29-b189-aa97-eea4-0340a72a6f67@redhat.com>
Date:   Thu, 2 Apr 2020 10:48:51 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20200401063817.gb5f4ah45qvtqkhw@kamzik.brq.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/20 3:38 AM, Andrew Jones wrote:
> On Tue, Mar 31, 2020 at 06:42:21PM -0300, Wainer dos Santos Moschetta wrote:
>> It would be nice to exercise the code by adding slots with different page
>> flags. But for this test that simple checks the limit, the use of
>> KVM_MEM_READONLY is enough. I will change it on v2.
> It would be good to test more memslot error conditions as well. Do you plan
> to expand on this test?

Yes, I do. For example, check memory slots addresses can't overlap.

>
> Thanks,
> drew