Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1757705ybb;
        Thu, 2 Apr 2020 06:52:39 -0700 (PDT)
X-Google-Smtp-Source: APiQypIQDSlvkVbSvABOgo1vHCVXhIWyCnB46Z4n9+ADmjGkZojuAE9NVg5wY3n+tJHmmWD6U47N
X-Received: by 2002:a9d:2a8:: with SMTP id 37mr2444294otl.202.1585835559690;
        Thu, 02 Apr 2020 06:52:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1585835559; cv=none;
        d=google.com; s=arc-20160816;
        b=qqeFB0m7kAX/fjABn8UYq3k/4/+95MEFSBdBos8WCKVcNq1WNfD7+DyB3r7UMro7IR
         22NVIdYBaf99RHirCtl7SfJeik2d1ydLFMX7r5/X/wXbbEMoaoadtm6S99xAvXYtRZL8
         /LxeCC8zERjGrwwgBNQ2U6jpkCUI+GQLYdCiNYNslNdfsY9/DCvhzRbIAh6HthoS8k+b
         lIaQDxE50MI2tg6wUKxJPQZSwz+KXWCAwZ4oMiQQK90up4ftPWyxyLKuyBuckvK+oJJI
         EDngb6lSu1b8Xgfe+DDBTpZL+prwhGqQeRMfe9SMOkM+BhFEoH8ERW23u5ptPGxKsJ8M
         yKyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=XtMCXp9RMOpHpLrXMs/LtFZs/LG7xzf+4VXlGjee1gg=;
        b=f0HcJnw8ueCJhifXXxnLNhU52nFnAEeajC639n6t0xHNE7CNKgiCDgjKJycpvHwYzI
         1z1AFz/E9mdAmsi6DxIAkqerGO45hVB+5yiqh2isC3BMuqvdQcneEUMowT/LAD78kI0G
         nll4+vPzQ5ZN7gvToi49H2yOIzvcivgCaQ51pnytek3aSm4KY8FCaNJio5XKeRN1l7Ba
         uBr2HWKm5w44+WkkjXgoqmc50PQMfxhg3gkGR8PXi3UQ4nQOcu8n6J8ed+IlZh4XXpU0
         BQ2wbyEN+yiccLgOLJo+1H6xEVv3wSNkmp8FArSbAjYMto1T6Mpm68gknOhsa500UKi5
         vxVg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id k1si2229404oou.60.2020.04.02.06.52.26;
        Thu, 02 Apr 2020 06:52:39 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732532AbgDBNv2 (ORCPT <rfc822;plusworld97@gmail.com>
        + 99 others); Thu, 2 Apr 2020 09:51:28 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:46892 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731579AbgDBNv2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Apr 2020 09:51:28 -0400
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 854E9128A0360;
        Thu,  2 Apr 2020 06:51:27 -0700 (PDT)
Date:   Thu, 02 Apr 2020 06:51:26 -0700 (PDT)
Message-Id: <20200402.065126.1342599499039366040.davem@davemloft.net>
To:     colin.king@canonical.com
Cc:     irusskikh@marvell.com, mstarovoitov@marvell.com,
        dbogdanov@marvell.com, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: atlantic: fix missing | operator when
 assigning rec->llc
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200401232736.410028-1-colin.king@canonical.com>
References: <20200401232736.410028-1-colin.king@canonical.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Apr 2020 06:51:27 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Colin King <colin.king@canonical.com>
Date: Thu,  2 Apr 2020 00:27:36 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> rec->llc is currently being assigned twice, once with the lower 8 bits
> from packed_record[8] and then re-assigned afterwards with data from
> packed_record[9].  This looks like a type, I believe the second assignment
> should be using the |= operator rather than a direct assignment.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.