Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1879295ybb; Thu, 2 Apr 2020 08:59:44 -0700 (PDT) X-Google-Smtp-Source: APiQypKTEAqes/yaiu6CCEMRq5q9kAVimhiugmZ6qgMHeYxiqLVQfVUWEX9AkcrL+XSRmtYFsQxQ X-Received: by 2002:a05:6808:287:: with SMTP id z7mr2834301oic.138.1585843183955; Thu, 02 Apr 2020 08:59:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585843183; cv=none; d=google.com; s=arc-20160816; b=jnaDmUN/8hrWyj4Hbaywe/IvWBxqFDthXmSBlzINVTbhmP3XQ2lXMlhD+fIgMA9sWU iFGo40OMTSRtVT/4N5F3dmpfyAkGmUI6fagoZrkSKR9hZUyqwNISv+8ZDKwDFlHXt2Hn w8ojBeOuclvzcybnxRTzG1RBX813tCQsJ//Mtp5K+OlkcxpLp4sR1sQ2FWiLdUGZPJhJ CDJGZ8cHveCJVVCZ90oUvrBvCCmY3xWaxRWEGjauuwORH561JyxxQy9gP490rPjkk3aA PYvwR+glLyvDd11HwGGJykmhCejAD19hVEJ2kjdaNEOUjUkywI831jjvPs92gT6AGHKX eW9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KN71Axi3R2DOnnEsCnv9ks/tbfgC0G4SVUAhgahUx30=; b=UEQyBAR85pZbEOYY73PAgoOvvVtgLjt+poS6YX5Y8ancheIkCj07/0YO2drpVodRp3 JEUx11HrZH2K6Rb5ZiESabgMhfYfVKQPu6W8T3rLl8DElrD1jkcwcsZffD/+eawwEG4K fI3O9/r1yVhDhq/QB0zh2C/U03+Oxp12IDlnnk0IEx48QH3FVmZVskBZY/CdvhxDxTNH j645QWP4LXrN0cW3jy+ai+0eUvEbxlIrQQXEoN+B3sFf2YUN34gU2K70+0p36xLvg1SX TCRMPGrr7ucA2DykULmyGPR50hXqNNUI0WqkO2SxYCrdzMg+V/Qa6ochuaeSTUGX5t7w VaLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=otzYCRNx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si2636089oti.128.2020.04.02.08.59.29; Thu, 02 Apr 2020 08:59:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=otzYCRNx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389568AbgDBP6Q (ORCPT + 99 others); Thu, 2 Apr 2020 11:58:16 -0400 Received: from mail.skyhub.de ([5.9.137.197]:42518 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389318AbgDBP6P (ORCPT ); Thu, 2 Apr 2020 11:58:15 -0400 Received: from zn.tnic (p200300EC2F0A0E00E5DA45869CAED91E.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e00:e5da:4586:9cae:d91e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 525451EC0469; Thu, 2 Apr 2020 17:58:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1585843094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KN71Axi3R2DOnnEsCnv9ks/tbfgC0G4SVUAhgahUx30=; b=otzYCRNxzjG3bT5gHzs421cwgrbkrbyBFIs+WVi8Zd5uA9EZuHNh9AT7nyW/NqiI7y2akZ VAfqjkZdx1gBj/wVPL4UKMkbmiBf5Y2u+HOrx9bwHAxiwiJACS0cXKW0/oiHb+c3dROiBK 3aWKW7D3xW+VVbzVKAdAkj2UTZy/wSc= Date: Thu, 2 Apr 2020 17:58:10 +0200 From: Borislav Petkov To: Nick Terrell Cc: Nick Terrell , "linux-kernel@vger.kernel.org" , Chris Mason , "linux-kbuild@vger.kernel.org" , "x86@kernel.org" , "gregkh@linuxfoundation.org" , Petr Malat , Kees Cook , Kernel Team , Adam Borowski , Patrick Williams , Michael van der Westhuizen , "mingo@kernel.org" , Patrick Williams , Sedat Dilek Subject: Re: [PATCH v4 6/8] x86: bump ZO_z_extra_bytes margin for zstd Message-ID: <20200402155810.GD9352@zn.tnic> References: <20200401053913.216783-1-nickrterrell@gmail.com> <20200401053913.216783-7-nickrterrell@gmail.com> <20200401093310.GA13748@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 05:33:03PM +0000, Nick Terrell wrote: > The code is currently written so that all the compression algorithms use the > same ZO_z_extra_bytes. It is taken to be the maximum of the growth rate > plus the maximum fixed overhead. Just a few lines above is the comment: > > # … Hence safety > # margin should be updated to cover all decompressors so that we don't > # need to deal with each of them separately. Please check > # the description in lib/decompressor_xxx.c for specific information. > > So I was been following the guidance in the comments. Please state that in the commit message when you send your next revision. > Does it matter? I’m not an expert here, Huh, you're only sending the code then? Or what do you mean with not being an expert? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette