Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     Sean Christopherson <sean.j.christopherson@intel.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
        "Kenneth R. Crudup" <kenny@panix.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Xiaoyao Li <xiaoyao.li@intel.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        Tony Luck <tony.luck@intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Jessica Yu <jeyu@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [patch 2/2] x86/kvm/vmx: Prevent split lock detection induced #AC
 wreckage
Thread-Topic: [patch 2/2] x86/kvm/vmx: Prevent split lock detection induced
 #AC wreckage
Thread-Index: AQHWCO7TQEdzxFpLhEGvPpyBQxsUlqhl9XCAgAADv4A=
Date:   Thu, 2 Apr 2020 15:44:00 +0000
Message-ID: <18758F52-BB97-4F47-9481-F66AF4465A06@vmware.com>
References: <20200402123258.895628824@linutronix.de>
 <20200402124205.334622628@linutronix.de>
 <20200402153035.GA13879@linux.intel.com>
In-Reply-To: <20200402153035.GA13879@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <748CE06D1F28FB468C86DF2FF95EBBD8@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9de6861a-f2fb-45d3-5ea6-08d7d71ca9e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 15:44:00.4380
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f/7bAuHDyOzgsZTRPq+vIdUHfRzsZRJYaUka1is7jRjACsDxzeMrj3m6KsLOHj+DJYunj72F8aBKWwOlWq8RgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4376
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Apr 2, 2020, at 8:30 AM, Sean Christopherson <sean.j.christopherson@in=
tel.com> wrote:
>=20
> On Thu, Apr 02, 2020 at 02:33:00PM +0200, Thomas Gleixner wrote:
>> Without at least minimal handling for split lock detection induced #AC, =
VMX
>> will just run into the same problem as the VMWare hypervisor, which was
>> reported by Kenneth.
>>=20
>> It will inject the #AC blindly into the guest whether the guest is prepa=
red
>> or not.
>>=20
>> Add the minimal required handling for it:
>>=20
>>  - Check guest state whether CR0.AM is enabled and EFLAGS.AC is set.  If
>>    so, then the #AC originated from CPL3 and the guest has is prepared t=
o
>>    handle it. In this case it does not matter whether the #AC is due to =
a
>>    split lock or a regular unaligned check.
>>=20
>> - Invoke a minimal split lock detection handler. If the host SLD mode is
>>   sld_warn, then handle it in the same way as user space handling works:
>>   Emit a warning, disable SLD and mark the current task with TIF_SLD.
>>   With that resume the guest without injecting #AC.
>>=20
>>   If the host mode is sld_fatal or sld_off, emit a warning and deliver
>>   the exception to user space which can crash and burn itself.
>>=20
>> Mark the module with MOD_INFO(sld_safe, "Y") so the module loader does n=
ot
>> force SLD off.
>=20
> Some comments below.  But, any objection to taking Xiaoyao's patches that
> do effectively the same things, minus the MOD_INFO()?  I'll repost them i=
n
> reply to this thread.

IIUC they also deal with emulated split-lock accesses in the host, during
instruction emulation [1]. This seems also to be required, although I am no=
t
sure the approach that he took once emulation encounters a split-lock is
robust.

[1] https://lore.kernel.org/lkml/20200324151859.31068-5-xiaoyao.li@intel.co=
m/=