Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Apr 2020 18:48:59 +0300
From:   Ido Schimmel <idosch@mellanox.com>
To:     Colin King <colin.king@canonical.com>
Cc:     Jiri Pirko <jiri@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mlxsw: spectrum_trap: fix unintention integer
 overflow on left shift
Message-ID: <20200402154859.GA2453139@splinter>
References: <20200402144851.565983-1-colin.king@canonical.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200402144851.565983-1-colin.king@canonical.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (79.181.132.191) by AM0PR02CA0041.eurprd02.prod.outlook.com (2603:10a6:208:d2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Thu, 2 Apr 2020 15:49:02 +0000
X-Originating-IP: [79.181.132.191]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: c26e05d9-1dd7-4e0e-ab95-08d7d71d5db5
X-MS-TrafficTypeDiagnostic: AM0PR05MB5105:|AM0PR05MB5105:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM0PR05MB51051753337067C649D2872BBFC60@AM0PR05MB5105.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-Forefront-PRVS: 0361212EA8
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB6754.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(7916004)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(2906002)(81166006)(33716001)(33656002)(52116002)(316002)(81156014)(1076003)(6666004)(478600001)(8936002)(6496006)(8676002)(4326008)(4744005)(54906003)(5660300002)(186003)(86362001)(66476007)(956004)(6486002)(6916009)(66946007)(26005)(16526019)(9686003)(66556008);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TBc2Hj25d5QQzyXaFcuPR47MoAojWiY5FkelZgy+aeTuxvMYPJU/4muC/d5MPB9FZLwIXWwiF0esBeC0KxWF2qqjSj5CrIxqtcvGVgQ99g6cA0rZbxmmPHmoq12ED/CIIo+9bFW4Z+GEBoCY/5BEtDp419mQg/SbO7dGpKky0NlSjWWJl13b532Cw9BhBBiM1WUYuXsfNpNNhB5rCAFuvkczvKAt+CyQDcsmTK/NvJ2nK4575RL2aw/9LbcWoeSHT5XwABZj60ROP3MoQ7tgs31zk29ouPG/8rZnPFJrEZPAZpWfuHfGW7Lz+BCdy6mk+bAouueI6fJ5AUlKXdKybJKeByqk9U5i19lUvBrZEnVf1gLQxY2slhmt6gyjkHPVce6Qa3V4LtHbMvknA5GqwQeG7orn50Mg0dyoG78R4WE73YpiAGbtKItS1qqT8XKo
X-MS-Exchange-AntiSpam-MessageData: Of4PgLZZDO3+aVY4NZGgPSvE96Q+iRLXhhXaT2ijJ7NuofafcnUYKVVmgzsgc4VUcOIr10h0B3ejQBknYFDTxe3pbyAB2p0jXjEv5ik4R+5V6MoB+qf6hFk5xLLIdFAvWJMsXWd8toMIMrA6zyD4PA==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c26e05d9-1dd7-4e0e-ab95-08d7d71d5db5
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2020 15:49:02.4296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZMBHS1xsAz+vmvUox2UDthpBrgDL2/RwznwkfJlv5WmB+gX7MUTyA06m17pqankXkuBipl7roAD8R1XQeWm7sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5105
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 02, 2020 at 03:48:51PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
> 
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 13f2e64b94ea ("mlxsw: spectrum_trap: Add devlink-trap policer support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

For net:

Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>

Thanks