Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] perf script report: fix segfault when using DWARF mode
To:     Andreas Gerstmayr <agerstmayr@redhat.com>,
        linux-perf-users@vger.kernel.org
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        linux-kernel@vger.kernel.org
References: <05e0d633-54b4-fb3b-3d08-8963271017ea@amd.com>
 <20200402125417.422232-1-agerstmayr@redhat.com>
From:   Kim Phillips <kim.phillips@amd.com>
Message-ID: <6a098ce1-1981-dcff-ea62-af5fc07ec7fb@amd.com>
Date:   Thu, 2 Apr 2020 14:07:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200402125417.422232-1-agerstmayr@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.252.0.18] (165.204.84.11) by BN6PR1201CA0006.namprd12.prod.outlook.com (2603:10b6:405:4c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Thu, 2 Apr 2020 19:07:54 +0000
X-Originating-IP: [165.204.84.11]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 47d680ef-08c5-4504-d337-08d7d7392708
X-MS-TrafficTypeDiagnostic: SN6PR12MB2750:
X-Microsoft-Antispam-PRVS: <SN6PR12MB2750BD125BC8483BBE13511A87C60@SN6PR12MB2750.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-Forefront-PRVS: 0361212EA8
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2845.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(346002)(366004)(396003)(39860400002)(6666004)(54906003)(6486002)(66556008)(4744005)(66476007)(478600001)(66946007)(16576012)(2906002)(5660300002)(8676002)(31696002)(36756003)(956004)(86362001)(4326008)(81156014)(16526019)(31686004)(81166006)(316002)(7416002)(53546011)(52116002)(44832011)(26005)(186003)(8936002)(2616005);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GOp7OrvVtCVG5TuxQVu4f+MbBtovrXrpaSqV4yGsl6xNa3/OH7w/zgtlSI8z9XVAk6Tyl3LRHWa70sVDhQogNybgA+dj1jP3PDTe0U6He3WGvOig9Um0SEx7Zuj4ojZs1A1rhjXTIhHgQA6k1n9ReKBnMU9bZRW9n4hnVVR6B63JnfvaSGIFfNjdbKH38n/DyCC+FmeS8U7/48WtKzNDt0WVpkF9z7W3D8uSWnuOR8cVX+MwIpPFkP1m8zvhRU0Hm1XFr3NSd5r4FXokoOjx3DfKibzbyeXm9MC/fviHofMp0uOX2x8HzZK8VaM5ifpRAiciaFMGFcMOKyqDdtVfDr5hTy/IpYXYrdHUD+G29j3wdzCpsEDivay4/jy7kTF+U6MWrZM3Jy31FSaFbsWzqmxPk0VU8VULPO1xqTsubmKbk5RLWZklG3oSORqoV27j
X-MS-Exchange-AntiSpam-MessageData: /DIshPDhnKNhgp7WP2RgziDCP8SLJCjnSq/9PvMxARf/rMMoXA+KyT8alnHRh+5Cm37WAG/4bfOU+CxttQM0m6uDwscr7f/gS9iyrCDEyVBnHYgUidG3uzAtSkp24qM5PbystuLpBT+D/M7dv1KKhw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47d680ef-08c5-4504-d337-08d7d7392708
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2020 19:07:56.7570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eGt0ftC/GSCO67a+NvQvOQ5PfgPnNe0UfIE+X509lupyCq9n8zMDrH7TQVDBHdsMbLRul88ATEauCDecCsM0mA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2750
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/2/20 7:54 AM, Andreas Gerstmayr wrote:
> When running perf script report with a Python script and a callgraph in
> DWARF mode, intr_regs->regs can be 0 and therefore crashing the regs_map
> function.
> 
> Added a check for this condition (same check as in builtin-script.c:595).
> 
> Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
> ---

Tested-by: Kim Phillips <kim.phillips@amd.com>

Thanks,

Kim