Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 8aP+kFMHG2NbOSUqrxqX4eOmPgtC/GFRtLsD9AhVn3A3HJCR6ZqB1ZXR1Oh3cq2HdmWvAAw3Uz
 H5oDM6+dggUw==
IronPort-SDR: LNIqXv5RqfuX6hbRiyE0+KsHS6NZfbSVjV2o6Ii+z5t+RDEf7+l2XE9UlNinHrVzG7hZ/Np0KY
 ZFzYqcrywAEg==
From:   Bernardo Perez Priego <bernardo.perez.priego@intel.com>
To:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Nick Crews <ncrews@chromium.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Daniel Campello <campello@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2] platform/chrome: wilco_ec: Provide correct output format to 'h1_gpio' file
Date:   Thu,  2 Apr 2020 15:33:30 -0700
Message-Id: <20200402223331.28300-1-bernardo.perez.priego@intel.com>
In-Reply-To: <20200313232720.22364-1-bernardo.perez.priego@intel.com>
References: <20200313232720.22364-1-bernardo.perez.priego@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Function 'h1_gpio_get' is receiving 'val' parameter of type u64,
this is being passed to 'send_ec_cmd' as type u8, thus, result
is stored in least significant byte. Due to output format,
the whole 'val' value was being displayed when any of the most
significant bytes are different than zero.

This fix will make sure only least significant byte is displayed
regardless of remaining bytes value.

Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.com>
---
Changes in v2:
- Keep original format and apply mask instead to resolve warning

 drivers/platform/chrome/wilco_ec/debugfs.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c
index df5a5f6c3ec6..a812788a0bdc 100644
--- a/drivers/platform/chrome/wilco_ec/debugfs.c
+++ b/drivers/platform/chrome/wilco_ec/debugfs.c
@@ -208,7 +208,12 @@ static int send_ec_cmd(struct wilco_ec_device *ec, u8 sub_cmd, u8 *out_val)
  */
 static int h1_gpio_get(void *arg, u64 *val)
 {
-	return send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
+	int ret;
+
+	ret = send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
+	if (ret == 0)
+		*val &= 0xFF;
+	return ret;
 }
 
 DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n");
-- 
2.17.1