Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2265901ybb; Thu, 2 Apr 2020 16:53:24 -0700 (PDT) X-Google-Smtp-Source: APiQypLMPyGrBKX8AdbqfbaXzdZSa60IzPwADh78XRzt2SOxgoxWFCK5GJdq6KNEA5XIV2K7wpiy X-Received: by 2002:a9d:32a4:: with SMTP id u33mr4599316otb.23.1585871604418; Thu, 02 Apr 2020 16:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585871604; cv=none; d=google.com; s=arc-20160816; b=IULEnw3oCeJjm6EZzzNNpB1LTjiwNgvCaNWFSne+9SiLjSOpR9N8HQrQlc4H6NCc2j xYxEvGBtjnRZDuPsse34aUntoCwu5FMLVD3OuSlJuP/lgJduURugtpUaokwY1RLaV9U3 QkCctBVoHFyvIIqeQRHd5ZRrcW/M/rAgyQZQ/ri6pQnzmI2y7KVFchPnMcZ9fIIUSpt+ B/SIwZK9kZ0YMjGh6nrqUVsUyfm3UXW1pew6eD9F6+YtDib0uYjDiTup8dkwlm8pj5Df 7KDPG3CcN7M3aN+mtiQbKo3peFWuWuveqvat1DiF6jiv3zBkTNjq/bApxAzTl+SJhOZ1 9sVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=dqJ98zPhLM+tdJlzifCE4+/QdEj75kGr2F6hTOU45+E=; b=mTMDYTVYZ4rnCM5NrE7CtvGsFe2GCYeJJyJixK5/bIfB8pIUN9WKyV97pKUBXav5zk r+6Mdd6lyCKTIe3DgDiTtpNw63WSLuRd97b54rY7t/Xyc4Dd2hS5VKqd/LDaKq5JleM9 z6o9t7rLJWYZ7/OmgGGoY2OsNw0Yg3XQoK+HXf/jz1z7DxNZ+bhajbwzsh8VODC9Mon2 rH18SPjRgNvArTh367tDjelAGLwQ8pb2Yzj59tajZOIYGJ+IzdkXi1fl0sQblrJLoYY0 jGN+Rqre90cbcfRl5JBqnBze8O+18tW8Y3DAox8X/iypPPGCKRae4lS6HIVaAXOvSEPJ AJ0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="V/Nrj35p"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si2963209otq.90.2020.04.02.16.53.12; Thu, 02 Apr 2020 16:53:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="V/Nrj35p"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390267AbgDBXvN (ORCPT + 99 others); Thu, 2 Apr 2020 19:51:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46762 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390216AbgDBXvN (ORCPT ); Thu, 2 Apr 2020 19:51:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585871472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dqJ98zPhLM+tdJlzifCE4+/QdEj75kGr2F6hTOU45+E=; b=V/Nrj35pCrHd54ozjeoGshcHKPYYyGUZN4T6zy63a13U0h9g2nsdsF1iQNM0piKnoRWlha o6m2Q39P/wEemd4oKVXuTlKaAaQAhBQaBktL7x0UyzKCZ82zWPZt3Sz/JVXhIo4rAFx1hX coBZ1ilbpvNMPxccu71AkQOETkF65Lw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-mUOBEZTRM_yz-7_vQJAxXw-1; Thu, 02 Apr 2020 19:51:10 -0400 X-MC-Unique: mUOBEZTRM_yz-7_vQJAxXw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA2ED107ACC9; Thu, 2 Apr 2020 23:51:08 +0000 (UTC) Received: from elisabeth (unknown [10.36.110.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E03A21001B3F; Thu, 2 Apr 2020 23:51:05 +0000 (UTC) Date: Fri, 3 Apr 2020 01:50:57 +0200 From: Stefano Brivio To: "John B. Wyatt IV" Cc: outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , Saiyam Doshi , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Remove unused code Message-ID: <20200403015057.7a972c79@elisabeth> In-Reply-To: <20200402021706.788533-1-jbwyatt4@gmail.com> References: <20200402021706.788533-1-jbwyatt4@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Apr 2020 19:17:06 -0700 "John B. Wyatt IV" wrote: > Remove unused code surrounded by an #if 0 block. > > Code has not been altered since 2014 as reported by git blame. > > Reported by checkpatch. > > Signed-off-by: John B. Wyatt IV > --- > drivers/staging/emxx_udc/emxx_udc.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > index 9c2671cb32f7..bbfebe331033 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.h > +++ b/drivers/staging/emxx_udc/emxx_udc.h > @@ -9,12 +9,6 @@ > #define _LINUX_EMXX_H > > /*---------------------------------------------------------------------------*/ > -/*----------------- Default undef */ > -#if 0 > -#define DEBUG > -#define UDC_DEBUG_DUMP > -#endif > - > /*----------------- Default define */ > #define USE_DMA 1 > #define USE_SUSPEND_WAIT 1 Formally, this is fine. But... think about it: this driver might be rather buggy, so the first thing one might want to do with it is to "enable" those two defines. In general, that stuff has to disappear, and proper debugging facilities have to be used, but with a driver in this state, as long as proper debugging facilities aren't there, you might be doing more harm than good. -- Stefano