Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2311882ybb; Thu, 2 Apr 2020 18:02:29 -0700 (PDT) X-Google-Smtp-Source: APiQypKaYMaOlmh3x7p9/2SXfyxVZBeiQ+xwBoV3xAMxdvR+4rtDTTTXZguhjIo1fhs4n+E2uYH2 X-Received: by 2002:a4a:d746:: with SMTP id h6mr4868808oot.21.1585875749666; Thu, 02 Apr 2020 18:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585875749; cv=none; d=google.com; s=arc-20160816; b=QcVaZubtrAJyvue4zTirMGpF506jKdG+2g0lV5Q+mdR3iFc6To4xYSMsgOgcszM/6E UnVca7kPu1w5+7qqtvkIe6jjPXh1k0go1g/goPsJR5ZlfV4P+wzI7aj4ErQfVwbb9Uv7 OTuhiqLv45j0kDso3gVidGVslTXsinpbiqcgbyfQdAob60di8EOtfqWPSkqv9xKZAZ5U zu+lBU8QO7uRaFFtlbs9x9VkYKeUCr+GlHeNMCI6j69cTchblomdWB5sIsbSrTW4BBqz bdL3XaIYohdcObF0pYu+sbHfTrwOvGJje+YKlvAPumwmrTaUrzQ42OG5YGaLoRtN+zPw +1tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=GXvxoWUH4sjCzIQoXSOIBcX0X9drc9adAyaUJaf2/oE=; b=msLF08Qbbg9NMMRTJeEyUEMGQTrErYZY/ukwyvWcyLUKO3KTuMmAzBpm6WX428EnDr OXW8HQUH4vIYAHrUeX9JhjiUBT1Txwk6Vf8VizRHrDOe6NsQR9PilRVUNuMdK1LbRhEN eX6qr7EeW6V33s9plIYy+Sh9hDzFrxofHVypeq+L0r02lazSk/Ji+QDpHfA1UaAp/2cC 21TBYSQryuvC2H24pTJCLtXyMGvFrPQtStIPRK/W6Ybio+16qRwy2ThYZ4GtWU4oP6gu HQMfJFXAu1t1/gjP7y4GhWZXI58pvVqloFxNyx8RBTfsXzlMXwMJU85g5BPvoyCucPoN 2dMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z126si2801873oia.187.2020.04.02.18.02.05; Thu, 02 Apr 2020 18:02:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390285AbgDCBAW (ORCPT + 99 others); Thu, 2 Apr 2020 21:00:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53748 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388961AbgDCBAW (ORCPT ); Thu, 2 Apr 2020 21:00:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 617C012757482; Thu, 2 Apr 2020 18:00:21 -0700 (PDT) Date: Thu, 02 Apr 2020 18:00:20 -0700 (PDT) Message-Id: <20200402.180020.506846856059927664.davem@davemloft.net> To: colin.king@canonical.com Cc: jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mlxsw: spectrum_trap: fix unintention integer overflow on left shift From: David Miller In-Reply-To: <20200402144851.565983-1-colin.king@canonical.com> References: <20200402144851.565983-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Apr 2020 18:00:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 2 Apr 2020 15:48:51 +0100 > From: Colin Ian King > > Shifting the integer value 1 is evaluated using 32-bit > arithmetic and then used in an expression that expects a 64-bit > value, so there is potentially an integer overflow. Fix this > by using the BIT_ULL macro to perform the shift and avoid the > overflow. > > Addresses-Coverity: ("Unintentional integer overflow") > Fixes: 13f2e64b94ea ("mlxsw: spectrum_trap: Add devlink-trap policer support") > Signed-off-by: Colin Ian King Applied, thanks.