Subject: Re: 2.6.16-rc4-mm2: drivers/isdn/hysdn/hysdn_net.c module_param()
	compile error
From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org,
       Karsten Keil <kkeil@suse.de>
In-Reply-To: <20060224232222.73803498.akpm@osdl.org>
References: <20060224031002.0f7ff92a.akpm@osdl.org>
	 <20060225033855.GG3674@stusta.de>  <20060224232222.73803498.akpm@osdl.org>
Content-Type: text/plain
Date: Sat, 25 Feb 2006 18:56:03 +1100
Message-Id: <1140854163.10212.18.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 830
Lines: 23

On Fri, 2006-02-24 at 23:22 -0800, Andrew Morton wrote:
> Bad Rusty should have chosen less generic-sounding identifiers.

I actually disagree with that, for three reasons.  Firstly, my namespace
didn't leak: I only appended these names to clear prefixes.  Secondly,
uint is already typedefed in types.h.  Thirdly, the short names are
clear and intuitive.

> Bad ISDN shouldn't have gone off and defined its own types, either.

That was poor, yes, but typedefs would have been less polluting than
#defines.

Hope that clarifies!
Rusty.
-- 
 ccontrol: http://ozlabs.org/~rusty/ccontrol

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/