Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp75421ybb; Thu, 2 Apr 2020 21:23:00 -0700 (PDT) X-Google-Smtp-Source: APiQypKsqDODK5Tb2y7zmhQPhxpRRbXyvB14PP15ncHIXDQxjyvzGNL4Jc5wrSQSUR0OnauRZi3Z X-Received: by 2002:a9d:949:: with SMTP id 67mr4987632otp.304.1585887780743; Thu, 02 Apr 2020 21:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585887780; cv=none; d=google.com; s=arc-20160816; b=mwBe2JjWfwV1ME7NJczwnKxffTun03w8SEbs71BUAEaBrOcROqo+ZzXf4NoxZXtYLw I0uQXhvMhcOgIVBO/jARk6rK5eKrRfp5J7sl9QH0Ua+DByNoQAxMGwKNHmdF59Hq8GpH gdvCAP6tIetNCULjGBF9JMNTGPFcCLqzVYNa6w5Jzx7rbSGxVuI9NcVmCfsnJLA9lMMP JcHgxLiK59TbVDGXyy89UpyDHZWsZUTomXCXL96Xa8oOg6cYqBEA03qkWaR4W16soDzR MHj9ErRKi2q7IsdeOJZ/Elcp2K2vib8+q/N6R2MUUK4lC9+HTiUFNNVWDCBl9Qu50e/U 4vAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5fPe6YxJJz5hpIUKDJYn0pPxNuPz/gZNfspWmjJwjoQ=; b=UzRTgsrHj1bB88bO0GwzCzRZMjLxFRh3UWoKfWxYnXFS9J8slR7trhkxmOXdmKsEow bEwaImfZr2dj1l3S2JqjTl6v64YYjMRl4FvBJMKxqY9yTCjpVhE8xoGJ+gJfBa064RKt MnETcPjBH9yPE/byH0ScmkNmO1yWLjh2Fnkul1V/K5+ltzo3WBk4RgcvMNwV3rnheMei 1NYVBGgVHCendTwCkoVMia6djFHk741sgeaUJOe3uPVvaFifHfzNn9bT1u52nYKzjJ2Z QwK7DHkMgecpeTDgotvvCPzNbmKD0k7Fb94s6RIfeRbvHjgUWMy8zSQbsbWMaeqpvMkG TJlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l143si2767500oih.269.2020.04.02.21.22.32; Thu, 02 Apr 2020 21:23:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728856AbgDCETO (ORCPT + 99 others); Fri, 3 Apr 2020 00:19:14 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:3378 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgDCETO (ORCPT ); Fri, 3 Apr 2020 00:19:14 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.1]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee25e86b92a542-6c6b2; Fri, 03 Apr 2020 12:18:52 +0800 (CST) X-RM-TRANSID: 2ee25e86b92a542-6c6b2 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee15e86b92ae84-15666; Fri, 03 Apr 2020 12:18:52 +0800 (CST) X-RM-TRANSID: 2ee15e86b92ae84-15666 From: Tang Bin To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] mfd:asic3:Delete redundant variable definition Date: Fri, 3 Apr 2020 12:20:20 +0800 Message-Id: <20200403042020.17452-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In this function, 'ret' is always assigned, even if 'pdata->leds' don't carry out,it has already been assigned a value in the above code, including '0',so it's redundant. Signed-off-by: Tang Bin --- drivers/mfd/asic3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index a6bd2134c..cee7454b3 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -924,7 +924,6 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, goto out; } - ret = 0; if (pdata->leds) { int i; -- 2.20.1.windows.1