Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp85683ybb; Thu, 2 Apr 2020 21:39:33 -0700 (PDT) X-Google-Smtp-Source: APiQypIRwDoTYY8Xm9Ex5mq8LRBphTKA5ogGNSjc5ob1jRLUqh0vxXb+pTaCe9K7VQuDjNpP4rCU X-Received: by 2002:a4a:a126:: with SMTP id i38mr5399360ool.11.1585888772895; Thu, 02 Apr 2020 21:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585888772; cv=none; d=google.com; s=arc-20160816; b=pH5A3lMd6HL3mSM+kNUcbIEEJ2HAhqmnZP6mvcky6RAVymtd2F8vf1QUGBvkKDlGVo 8vGQxn2ZaXI8i7k9S06BFhXjqhdNNgYB5/qASV0YyKmWA4iv4Zt47lf/RJ5lvoxOkzR7 s3sM4s4UZIDrQhFhczkQFENKzuibUzCO/0204zrp87haEGyivpSRCTlL/uauree49q10 kympBe4KwRCACPK5Y50LT5yE9eYWz7hDWjbPkmXAOnPmlL07oJCQSwoA/iSm7B6YQYAk SQBzWR+I6iI8u1gW7ITTWNsiCMN8JMzA+Qh5G8eprDItSY+388Gej/5n3xzJ9M7e7u3i WBcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=Qq3aeaJ0OcjREO/GSM36ydUslwnpUtzoKF2idEKWK/o=; b=yB1BpWlLGkZTD2W4kELcn+MIi1f4Dv94pg8g76Hp9EUfy0PxhUP3hTtL6Mo9GBc1ZV +X55kvzelpihLpExjrHPokQ3cDa/ZWzNLb8crJCDGIE7l7FpJitkkRISOmueaH3Fi9M6 sVGy4e4iz8t8TPHOo2KruwMyeR+j527UtNkhuUay/hWkAqVQGQpqzePog+HgwHl3XpvW yBIvs2J4VdsstmHzlTJTBYjMzZLM5CnYjoNR4/VdPrv5x5YSS6ZeSZbUa1MPVoLgduZd MEk7YwhBjpAgjicnoVbVKL0O2kAFVWeR6FqUIaW1xOF/iJwrOmIQV0GcZVnk7xumUFLh pwYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Vsp7iefS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b205si1481037oif.126.2020.04.02.21.39.19; Thu, 02 Apr 2020 21:39:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=Vsp7iefS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730025AbgDCE1m (ORCPT + 99 others); Fri, 3 Apr 2020 00:27:42 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:36207 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgDCE1l (ORCPT ); Fri, 3 Apr 2020 00:27:41 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48tn3F11cNz9sRR; Fri, 3 Apr 2020 15:27:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1585888059; bh=P6pDV2mWC3/QGwHFGntoCWhQeeo1qFFM1tqWOPVJ5GQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vsp7iefSuq2qUc2BqgDgoqQSz9nPDU/JrItc+oEyG61KFugv7uQPx8toJGFzcyDE9 fbHOnTwHuQ5nU9Y2XDcNSY0Z2d2hDCzlqQhElxnt0lWMHCdM5Xj8YLhG/Gvt02ZsjQ H2QG7o77rzF7weuVSVcwCohP50hpM4jeI0X/jbE8sTucOI8vacLjjbZb6LfDQZrQvF s44uAO8q4NgYv5YD8W76eyM++ks7SvH51Mshmbfai8akqeelai+Lq2HG+OMgjeqjzs QWv7sKW0TVJeK8e+qAjnA0G4PeqL7511jU+g7m3hAZHA3+DqAaMDtXDp7bogX/2lG5 13TfLzlBAQuTQ== From: Michael Ellerman To: Benjamin Herrenschmidt , Dan Williams , Alastair D'Silva Cc: "Aneesh Kumar K . V" , Oliver O'Halloran , Paul Mackerras , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?utf-8?Q?C=C3=A9dric?= Le Goater , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Subject: Re: [PATCH v4 03/25] powerpc/powernv: Map & release OpenCAPI LPC memory In-Reply-To: References: <20200327071202.2159885-1-alastair@d-silva.org> <20200327071202.2159885-4-alastair@d-silva.org> Date: Fri, 03 Apr 2020 15:27:46 +1100 Message-ID: <87v9mhry65.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benjamin Herrenschmidt writes: > On Wed, 2020-04-01 at 01:48 -0700, Dan Williams wrote: >> > >> > +u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size) >> > +{ >> > + struct pci_controller *hose = pci_bus_to_host(pdev->bus); >> > + struct pnv_phb *phb = hose->private_data; >> >> Is calling the local variable 'hose' instead of 'host' on purpose? > > Haha that's funny :-) > > It's an oooooooold usage that comes iirc from sparc ? or maybe alpha ? Yeah it was alpha, I found it in the history tree: https://github.com/mpe/linux-fullhistory/blob/1928de59ba4209dc5e9f2cef63560c09ba0df73b/arch/alpha/kernel/mcpcia.c And airlied found an old manual which confirms it: The TIOP module interfaces the AlphaServer 8000 system bus to four I/O channels, called "hoses." https://www.hpl.hp.com/hpjournal/dtj/vol7num1/vol7num1art4.pdf So at least now we know where it comes from. It's also used widely in mips, microblaze, sh and a little bit in drm. cheers