Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp135901ybb; Thu, 2 Apr 2020 23:03:31 -0700 (PDT) X-Google-Smtp-Source: APiQypJ5b8XuVaC064Yf4vVQFZBi1uK2B+N5AJZkl3NhPcH7ukGkbvk3PFxWrJz2AIPzH1jfS+Nv X-Received: by 2002:aca:f084:: with SMTP id o126mr1956660oih.81.1585893811696; Thu, 02 Apr 2020 23:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585893811; cv=none; d=google.com; s=arc-20160816; b=FhdARepg5yb7VvQp8nbGS5bv1e3xIbsFzfyY6hd4baXt9ewKysggR12dlHuFxXt9SS DsIhEQxI/9+PfgFgkiAXB6wApAE2H5c4YO3v7sW/R0R+Ks+WXje6UbN+feS1gxDTqGoU QxEhNn/yrrkYr8Uj/i/ooj40pudm0b4dTCGiBWPoMEcGIQzE7QGh/WMsPAUw+FsV295c 7tWkeHV4WmmlGq4B8oyAv7EzT8hWDOxS2S82p7KXLFtXlIy92AVJqkoWtz095CV5N1hI sCNmPyoCqaswcA9dN307IJcvTHYT9nz0EJFmwlB2oFsHnh3gfYtqhksgxmVzZj83zQYV Omgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=u5Oi5vTjQrKFdVWvpDim+5lX44FlytVdTDoAcj0jJrc=; b=NOAUl54ze0wXZcYbArhbncVhPthy1utcaL8rnEygXSZxw64hacecytcVQwx7vupxrS tBx1l1kohDpAERsq+gzulR1EuQMa+G/XibancZncl/o/QgzNLliDACOqtalFpn4JoEtS GW14xdvbeyrh0OBps/7vHUhZYsXRKrGsalFk+IdRf8+1otZMBHuNH6cZuQt5Gnp4GjlD 1IqbYZ4nRB+5jyut9/3KT3M2ZcQ85twKHnnr/L2LCoShxyaLQdNyAdiIlOYQVtpQMUHM /oK/ufVk4ddh7DaNtqFwvho8UEFNURmOAcc+FbEGk7cGkl8CtMTDRVxeOs/jhEYRPD5m K/ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="QKav23U/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w81si3223851oia.48.2020.04.02.23.03.18; Thu, 02 Apr 2020 23:03:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="QKav23U/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387544AbgDCGBl (ORCPT + 99 others); Fri, 3 Apr 2020 02:01:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:39720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729349AbgDCGBl (ORCPT ); Fri, 3 Apr 2020 02:01:41 -0400 Received: from localhost (unknown [171.76.107.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19CB6206F6; Fri, 3 Apr 2020 06:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585893700; bh=p2IuVwkph+/SUR16YqbpBqb56Vyf1fYOzyLt2WbYoB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QKav23U/eh6h/UhxXS/ncKxL41JZk1qm0n5hpfLHzXL0ONIxq+/ZuqChX9TyH49dI eKvRgnzQOuoAVCmL62/441OrFBkq2FrvtPqwQ+N7TAlBRl4lJk5QUGCbPOQhfKc8JC Z/x/weXzdPtovzgoqretYp6zsUfL3N1DnfrgIdCc= Date: Fri, 3 Apr 2020 11:31:27 +0530 From: Vinod Koul To: Wesley Cheng Cc: agross@kernel.org, bjorn.andersson@linaro.org, kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, p.zabel@pengutronix.de, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 2/5] phy: qcom-snps: Add SNPS USB PHY driver for QCOM based SOCs Message-ID: <20200403060127.GM72691@vkoul-mobl> References: <1585880634-15222-1-git-send-email-wcheng@codeaurora.org> <1585880634-15222-3-git-send-email-wcheng@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585880634-15222-3-git-send-email-wcheng@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-04-20, 19:23, Wesley Cheng wrote: > This adds the SNPS FemtoPHY V2 driver used in QCOM SOCs. There > are potentially multiple instances of this UTMI PHY on the > SOC, all which can utilize this driver. The V2 driver will > have a different register map compared to V1. Some nitpicks below, otherwise: Reviewed-by: Vinod Koul > +/** > + * struct qcom_snps_hsphy - structure holding snps hs phy attributes > + * > + * @phy: generic phy > + * @base: iomapped memory space for qubs2 phy > + * > + * @cfg_ahb_clk: AHB2PHY interface clock > + * @ref_clk: phy reference clock > + * @iface_clk: phy interface clock > + * @phy_reset: phy reset control > + * @vregs: regulator supplies bulk data > + This is missing the marker * for kernel doc > + * @phy_initialized: if PHY has been initialized correctly > + * This empty line is redundant > + */ > +struct qcom_snps_hsphy { > + struct phy *phy; > + void __iomem *base; > + > + struct clk *cfg_ahb_clk; > + struct clk *ref_clk; > + struct reset_control *phy_reset; > + struct regulator_bulk_data vregs[SNPS_HS_NUM_VREGS]; > + > + bool phy_initialized; > +}; > + > +static inline void qcom_snps_hsphy_write_mask(void __iomem *base, u32 offset, > + u32 mask, u32 val) coding style mandates that second line should start at preceeding line opening brace :), so can you please make it: static inline void qcom_snps_hsphy_write_mask(void __iomem *base, u32 offset, u32 mask, u32 val) -- ~Vinod