Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Apr 2020 11:50:06 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Baolin Wang <baolin.wang7@gmail.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Qais Yousef <qais.yousef@arm.com>
Subject: Re: linux-next: build failure after merge of the tip tree
Message-ID: <20200403095006.naztbhspp6vcv5hl@earth.universe>
References: <20200326135258.2764f0de@canb.auug.org.au>
 <20200401121431.6a996244@canb.auug.org.au>
 <CADBw62qar4qPJmjZj1+9tb6sgqUcCrjei6G62wPaH=YVf48=zA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="i5yah2e7albqxil4"
Content-Disposition: inline
In-Reply-To: <CADBw62qar4qPJmjZj1+9tb6sgqUcCrjei6G62wPaH=YVf48=zA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--i5yah2e7albqxil4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Fri, Apr 03, 2020 at 04:15:11PM +0800, Baolin Wang wrote:
> On Wed, Apr 1, 2020 at 9:14 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Thu, 26 Mar 2020 13:52:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > drivers/power/reset/sc27xx-poweroff.c: In function 'sc27xx_poweroff_shutdown':
> > > drivers/power/reset/sc27xx-poweroff.c:38:4: error: implicit declaration of function 'cpu_down' [-Werror=implicit-function-declaration]
> > >    38 |    cpu_down(cpu);
> > >       |    ^~~~~~~~
> > >
> > > Caused by commit
> > >
> > >   33c3736ec888 ("cpu/hotplug: Hide cpu_up/down()")
> > >
> > > interacting with commit
> > >
> > >   274afbc3ad33 ("power: reset: sc27xx: Change to use cpu_down()")
> > >
> > > from the battery tree.
> > >
> > > I have added the following merge fix patch:
> > >
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Thu, 26 Mar 2020 13:42:00 +1100
> > > Subject: [PATCH] power: reset: sc27xx: use remove_cpu instead of cpu_down
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  drivers/power/reset/sc27xx-poweroff.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc27xx-poweroff.c
> > > index 69863074daf6..90287c31992c 100644
> > > --- a/drivers/power/reset/sc27xx-poweroff.c
> > > +++ b/drivers/power/reset/sc27xx-poweroff.c
> > > @@ -35,7 +35,7 @@ static void sc27xx_poweroff_shutdown(void)
> > >
> > >       for_each_online_cpu(cpu) {
> > >               if (cpu != smp_processor_id())
> > > -                     cpu_down(cpu);
> > > +                     remove_cpu(cpu);
> > >       }
> > >  #endif
> > >  }
> > > --
> > > 2.25.0
> >
> > This fixup is now needed when the battery tree is merged into Linus' tree.

Thanks for the reminder.

> Thanks Stephen.
>
> Sebastian, could you pick up this patch to avoid the compiling issue? Thanks.

I will point Linus to this patch when I send my pull request.

-- Sebastian

--i5yah2e7albqxil4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl6HBsIACgkQ2O7X88g7
+ppzuA/9EawF4CCezOXd0X6nTWA7BYgnr691iy6p6HssXAqJaryld64vUEDxugeh
cOrQfz8L5VMViTGWpPYsjad2YEAJGzLAUB+2Mrf1cICjC1qUztK8fa6j1zK0T2bu
eT7KQVQ8rSAYfhqh9NTPSTMj9xDowtEyXJBasNbFef3HTcpHlxOz5DY19tEjDGFD
+rJAMBBCNiysAg59JySA9rADGTAE0lEbNRIlM7MN3+Wuywth0N++Vl+CxVYclpR9
y8NzBIyghYPbuViP5rbwDE6erSvc5i8x/dgJ4rSgaTLnFg+z5C1chvZOUisQ9MCr
h7z91rpp7+ikMlU/1R5lg2OwtT88gFShfLc9B603uQl0uNpgqyVg1NpdhiYwDgdy
rELgk6zXPrBHqY/4HCfEAix09j9Oz3cx7ND6f839qHBE8R2ZwLEFBvJ7b5wRV+n8
TzHUloPBC9tNvOUObqDjbSSxvlYt/2ig32kbAMJ2OJGgdAUJBK8NhzxCNmWAcQn0
yEiv+aC438Hhhxx5vYspjmJRAVYu8ViRAgx0Lm3XSMCh5exUM8Sga7fVNmCEESdU
nU3y6Vv7gDDynpLHIf0SPULBjrvnSk0coKfqw+ky6KPCEzUVWZjcY4+ZTr+kb1P7
aaX8TWrzXimdNlBOAqCJFOylO4xMA67axX+D0sTn89Bhgc+PD1Q=
=vUvp
-----END PGP SIGNATURE-----

--i5yah2e7albqxil4--