Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp452086ybb; Fri, 3 Apr 2020 06:01:58 -0700 (PDT) X-Google-Smtp-Source: APiQypKwIT8Qo0mLsGZxMWlGQIFfdptGI3snuzYBwzhNoqURxTJzpLM0+UGallH+Jt8sEfmyjHM5 X-Received: by 2002:aca:646:: with SMTP id 67mr2780017oig.4.1585918918125; Fri, 03 Apr 2020 06:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585918918; cv=none; d=google.com; s=arc-20160816; b=CySQoEjYSGHDeB5Dz6feAWGuXbvAXDcgC83SdWAGN7633xt7x+2H/EF+F3Xl2AiZ3t q0lUQi0dkRhRrVbpz0hwfMN66cKsC0srg0YYBlZ9xhsYvW2ro7yU41TJdWPOvdprGTz1 eREOvzKfO7hKd8vuTHSiiwQ0Z0jWG8i2MvQUbCCaT/pSAIZEaG/WJc0PGuM4dlkM21Vr g0Wo2JQtQqqimWo0/7FugybcejXf5+WRs6gG4hjTTQ2f4/+qBhCDnR93lll+F2eMsZDH pn467EdxbFCAzj8DDcN8zjvbcXR56iSyyTx3bCfMjmNQVA2n9xS884ecvfRSpyGlIFug WJ8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7SS9MeRqSIElKXBRRy/iM4tRtXsvU9V0Neex/siiw+s=; b=mNbJvZzuOIMmygvlHvzBLMjErE2SvNev1GxsK7QmiG1s4A+IH6/jbc6ZzkUsFSRYaU gUWKLdJJpzRjo5Pkpg06Zucpd+FkwVkawPRKHXZtjyol3JmGYp2fZHDcTPeqL4YnAPq2 jxdXeMv3n4gD/dsdonJoKAt6OihTScV8RGROUzoQI2gsShCjh/fjkD9FEEgNJW9hSeZF wjZCKW14GCZEQPotnAehxbMvAWSnl1+K6afPHNzF349/lYoVuEpXV6LlrxuXfqn50/a6 DddHRpDFuvp1ESDuHQjiTKycH/VjrEr7emfi0vW0HDjYBB0UcIfaagiKSH/5fZ4Aeyov lMuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=P2AND8XD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si3633648oti.159.2020.04.03.06.01.44; Fri, 03 Apr 2020 06:01:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=P2AND8XD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390806AbgDCMlS (ORCPT + 99 others); Fri, 3 Apr 2020 08:41:18 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52842 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727965AbgDCMlS (ORCPT ); Fri, 3 Apr 2020 08:41:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7SS9MeRqSIElKXBRRy/iM4tRtXsvU9V0Neex/siiw+s=; b=P2AND8XDBYw3d2Id4IRc9mwrxE tq2sRN+RoWfEVbGiXT5nCB0U0fSg5yO9uAPb3NWuQsRB6e9hz1hzaMzupRufuDY72KkRMg8Lhlgoj 9OHHbSzSdRXdjKwqHQcy0byZO3ZJWln8noUjsFrSUqq+jyqF7C6tBb/gtB1vj/jGuLUPRax+inG25 ITjW5m9mHy56hkGf90PZe2CTFhXQE4m1SArQGl+Yt/BbiRKNlwAZNCahDLx4pAVxVE8qyDNbq+rBH 4fmLzA2Wepsy8pHPYbKLFewJI45tb3OAjG2NTrd1aX4XXPxxzW0jvAaANaXue+zzWXD4VCcFaHeqC qKwUGF1g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKLdG-0006eI-LD; Fri, 03 Apr 2020 12:41:10 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A88A830477A; Fri, 3 Apr 2020 14:41:07 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9161D2B12078B; Fri, 3 Apr 2020 14:41:07 +0200 (CEST) Date: Fri, 3 Apr 2020 14:41:07 +0200 From: Peter Zijlstra To: Julien Thierry Cc: Josh Poimboeuf , Alexandre Chartre , x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH 3/7] objtool: Add support for intra-function calls Message-ID: <20200403124107.GO20730@hirez.programming.kicks-ass.net> References: <20200402082220.808-1-alexandre.chartre@oracle.com> <20200402082220.808-4-alexandre.chartre@oracle.com> <20200402154919.2c6shw4hfreagchg@treble> <3d075cb2-8d99-5ab7-4842-efef1964247d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d075cb2-8d99-5ab7-4842-efef1964247d@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 03, 2020 at 09:01:38AM +0100, Julien Thierry wrote: > > Last I found is in qcom_link_stack_sanitization() [2], but that's just a > workaround for a very specific hardware. In my local tree I just put the > function as STACK_FRAME_NON_STANDARD. But the code just saves the return > address, has 16 call instructions that just call the instruction after them, > restores the return address and lets the C-function return normally (and it > somehow fixes something for that hardware). > That sounds very much like the RSB flushing we do.