Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp486250ybb; Fri, 3 Apr 2020 06:36:22 -0700 (PDT) X-Google-Smtp-Source: APiQypKr51/yIzTAvh0K7oumio7wkHZ5WloCiOeo2nKFAKhQ9Rcd4pZ02L5pQSlSSNMPNpH1qJbA X-Received: by 2002:aca:f384:: with SMTP id r126mr2893545oih.41.1585920982246; Fri, 03 Apr 2020 06:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585920982; cv=none; d=google.com; s=arc-20160816; b=ivWHIHFT+prlhEDNkFbYmwfAPE47IsrPJUUGaComdp3udcrZXDkxNX9yvr2IvfC7Vs Mu24eXwTfBe0Dv24VZKSJ5Wgjoz56JhDJap+OrP1uCy+HLMQk7a2I+iK/rI8uqrhcunh kVD+o6Zk5t4w2t+mEa5SbX6ja5ofJcGTPs0TAG7ug7LHrTTpimDY/rv7ixlmzmzFuYSP 7V78q3XyJR3njHkpCej4p088hpIfUcSizddof+8HF92UZt2/nN+cv1FsElfR1mH/StQH myFfbJubLYFvhf2A79zjn7fxwaqzPuQkLZDazE97HlKS5FDklvfCZFwCMH9Au/3jOUGF 9XfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=Fv+UOKy4KHt2Z9usek/+CovcC6jaN8rXPg7IhrjHeJc=; b=mZzVfaIfVnvvLFjiWn2E6AWr1nj+qfq2DwZGO+FhuoUqFwAJhgXtNYSkiwUIL3MciA fg37h11hqz8UP6RCLrVVKUg2r3StzhFHEyRo+bc0W+SdqT3gJUINYy+2CVvaf4AZxe9d vd7pZVNvt0Uvu+/kuNeymPeriZdszQ322o2aJUt0bpH51g5hdDQxcwCshyZXX/AuAH+K PzAGhgftIOfls0/QOjVo1De4arDZ/sFVQKJ9Bt1DYr2Jy9K8Ztc+t4bXE+WPy8WQcyKd Eyq9SEBA7Ex5jjqL8Iut6BnQ2t0lnBq/N6Ki+QkXMa5ylpEvOppRT90DQBH8G4qXL6Zf w+yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Od5mHxiE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34si3410346oth.307.2020.04.03.06.36.08; Fri, 03 Apr 2020 06:36:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Od5mHxiE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390775AbgDCNfg (ORCPT + 99 others); Fri, 3 Apr 2020 09:35:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33836 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727431AbgDCNff (ORCPT ); Fri, 3 Apr 2020 09:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=Fv+UOKy4KHt2Z9usek/+CovcC6jaN8rXPg7IhrjHeJc=; b=Od5mHxiEexHfiHhDYreDpAjqc2 HoL9QFJUHhnmyc0umq4xGl+rKisEKFaEUXgSqbfbg6yYyQsy9WM+WfEPBks+D8xH5Jc21ZX+PjSzA Gv6PHcrrMR2ckHx2QgIsfc7gKMvILb/9dcI3lr03m+0BDjZ/x7srP+bsJ29Yo5vd1/Ktw1NRGZt8R gv4+71LE0qGQukKBUMwYCOfYvHg+ngRecjIYNphecSHc/Em3q89N9DeBkI408jkIj1wjvIqJI5mvA dIwd/8pZEdDDDkKibFlXfmTZgYPQPwrCAAgf2clmhs6EBNjZWcvjpdXtTEtvBW//e2i354xKHw7E5 +Z7AqNOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKMTt-0003hr-58; Fri, 03 Apr 2020 13:35:33 +0000 Date: Fri, 3 Apr 2020 06:35:33 -0700 From: Christoph Hellwig To: Daniel Borkmann Cc: Alexei Starovoitov , Linus Torvalds , Masami Hiramatsu , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Question on "uaccess: Add strict non-pagefault kernel-space read function" Message-ID: <20200403133533.GA3424@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, I just stumbled over your above commit, and it really confuses me. Not the newly added functions, which seems perfectly sane, but why you left the crazy old functions in place instead of investing a little bit of extra effort to clean the existing mess up and switch everyone to the sane new variants?