Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Apr 2020 11:20:16 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Yafang Shao <laoar.shao@gmail.com>
Cc:     peterz@infradead.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Daniel Drake <drake@endlessm.com>,
        Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH] psi: fix randomized calculation in record_times()
Message-ID: <20200403152016.GA69203@cmpxchg.org>
References: <1585904125-2819-1-git-send-email-laoar.shao@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1585904125-2819-1-git-send-email-laoar.shao@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 03, 2020 at 04:55:25AM -0400, Yafang Shao wrote:
> @@ -690,7 +690,10 @@ static void psi_group_change(struct psi_group *group, int cpu,
>  	 */
>  	write_seqcount_begin(&groupc->seq);
>  
> -	record_times(groupc, cpu, false);
> +	if (groupc->total_tasks)
> +		record_times(groupc, cpu, false);
> +	else
> +		groupc->state_start = cpu_clock(cpu);

This change appears is a no-op. If there are no tasks,
groupc->state_mask is 0, and the only thing record_times() does is

	groupc->state_start = cpu_clock(cpu);

Did you encounter actual problems, or are you just reading the code?