Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp618562ybb; Fri, 3 Apr 2020 08:48:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJ9AvYzcvT7OtttYsGWL6wMVROUD/CN79WamVbvnqA+zvGOHCuskC5W5/eUOAXOEswTSM0s X-Received: by 2002:aca:f346:: with SMTP id r67mr3600456oih.39.1585928905199; Fri, 03 Apr 2020 08:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585928905; cv=none; d=google.com; s=arc-20160816; b=eeMgBzcCTOmMfo2Ayf/gW4LHLa/kx+t1EXXSLhJVD0PZ6o2eglDuzoLdmiPuGAKJdh P8B7dgS+umn7w9dpVI21BoY4KOYvNq9TsVov7jFjh4b8uDLFzcKnLRjO0Fu+PAkuJ/li WCU4Y7bo3bil/RGXKc4Q6/TQpk6/nDsfU3qGfUlhV6Eu0M+armv6C4WhDPwYIJVrXght SNCUJrscYSdiJgOPwcRyztyTjXCoQIUpWGjrCDNx1k1TrRtJYjRnQLCptoENdHjOUHD/ lvS+oSYGaQMmbk52sDuQRqE/Obvo1yVRJEi6747rZrVa9c/majxHz7bUWbAGW/Fx/U9v PqnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oH2OHy+Eyviif1iebcrHo18si9PoFShEfkJbOhyf4JQ=; b=ZBocBpRHwtLj57E/sP+w8/yO+IW8nXlPpvei8ewlGnPIGeKOAM3uanvXiAEawDjp4b ItBDi6zdlKtTScS7B7w8s2DwMeZthxt0zX4psQgul8iLsOAS9VaK23f68t0DDb9OMQFO z8MDlaOEWN+jYeyyTWZ3ouglOzNnAVWWLQB9RzEDhTRf75OOoQRlY058JizPSYWApmF9 PzYqrlnvyeMqhE/gSukZw3CkWky9PbxtVrotllBveuc/LQU/m+xriYNN25Ox4ad1uoe4 XJkNe78x0xTTA6d4XlAbWdx/w/+Psdpr1nJAuT82FPPQhE+EyDKfBdjETFiLNnA+LuN+ DkVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F+3kh5Xi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q126si3781002oia.55.2020.04.03.08.48.12; Fri, 03 Apr 2020 08:48:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F+3kh5Xi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404260AbgDCPbB (ORCPT + 99 others); Fri, 3 Apr 2020 11:31:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:34047 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728203AbgDCPbB (ORCPT ); Fri, 3 Apr 2020 11:31:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585927860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oH2OHy+Eyviif1iebcrHo18si9PoFShEfkJbOhyf4JQ=; b=F+3kh5XiBcMkrLxp1/8445OrTNLsCpK9/A8KP6idXIUQ1fSgfcaxZg4iKm2yW/dttolYS2 hKXPRSMWa0kD25qKCYBq0us9xoa3a9u5L5YmmAfBj+ftenxQ+LjG80YI3B6enZ53BLfS2Z aDjSLNbfA8XPgUHozhnrh1J9SozRb5M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-UbVvYl2_PIi2GI5z_52vtQ-1; Fri, 03 Apr 2020 11:30:58 -0400 X-MC-Unique: UbVvYl2_PIi2GI5z_52vtQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6082C190B2A2; Fri, 3 Apr 2020 15:30:57 +0000 (UTC) Received: from t480s.redhat.com (ovpn-112-213.ams2.redhat.com [10.36.112.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2AF0A26DC4; Fri, 3 Apr 2020 15:30:51 +0000 (UTC) From: David Hildenbrand To: kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Heiko Carstens , Cornelia Huck , Janosch Frank , Christian Borntraeger , David Hildenbrand Subject: [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups Date: Fri, 3 Apr 2020 17:30:45 +0200 Message-Id: <20200403153050.20569-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some vsie/gmap fixes and two cleanups/improvements. Patch #1 fixes an issue reported by Janosch. It was never observed so far= , because KVM usually doesn't use a region 1 table for it's guest (unless memory would be exceeding something like 16 EB, which isn't even supporte= d by the HW). Older QEMU+KVM or other hypervisors can trigger this. Patch #2 fixes a code path that probably was never taken and will most probably not be taken very often in the future - unless somebody really messes up the page tables for a guest (or writes a test for it). At some point, a test case for this would be nice. Patch #3 fixes a rare possible race. Don't think this is stable material. Gave it some testing with my limited access to somewhat-fast s390x machines. Booted a Linux kernel, supplying all possible number of page table hiearchies. v1 -> v2: - "KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks" -- Fix WARN_ON_ONCE - "gmap_table_walk() simplifications" -- Also init "table" directly David Hildenbrand (5): KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks KVM: s390: vsie: Fix delivery of addressing exceptions KVM: s390: vsie: Fix possible race when shadowing region 3 tables KVM: s390: vsie: Move conditional reschedule KVM: s390: vsie: gmap_table_walk() simplifications arch/s390/kvm/vsie.c | 4 ++-- arch/s390/mm/gmap.c | 17 +++++++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) --=20 2.25.1