Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Originaldate: Fri Mar 27, 2020 at 4:29 PM
Originalfrom: "Alex Dewar" <alex.dewar@gmx.co.uk>
Original: =?utf-8?q?dma=5Fpool
 =5Fdestroy()_already_checks_for_NULL_arguments,_so_th?=
 =?utf-8?q?e_extra_check=0D=0Ais_unnecessary.=0D=0A=0D=0ASigned-off-by:_Al?=
 =?utf-8?q?ex_Dewar_<alex.dewar@gmx.co.uk>=0D=0A---=0D=0A_arch/arm/common/?=
 =?utf-8?q?dmabounce.c_|_6_++----=0D=0A_1_file_changed,_2_insertions(+),_4?=
 =?utf-8?q?_deletions(-)=0D=0A=0D=0Adiff_--git_a/arch/arm/common/dmabounce?=
 =?utf-8?q?.c_b/arch/arm/common/dmabounce.c=0D=0Aindex_f4b719bde763..a7c77?=
 =?utf-8?q?6cdc38f_100644=0D=0A---_a/arch/arm/common/dmabounce.c=0D=0A+++_?=
 =?utf-8?q?b/arch/arm/common/dmabounce.c=0D=0A@@_-560,10_+560,8_@@_void_dm?=
 =?utf-8?q?abounce=5Funregister=5Fdev(struct_device_*dev)=0D=0A_=09=09BUG(?=
 =?utf-8?q?);=0D=0A_=09}=0D=0A=0D=0A-=09if_(device=5Finfo->small.pool)=0D?=
 =?utf-8?q?=0A-=09=09dma=5Fpool=5Fdestroy(device=5Finfo->small.pool);=0D?=
 =?utf-8?q?=0A-=09if_(device=5Finfo->large.pool)=0D=0A-=09=09dma=5Fpool=5F?=
 =?utf-8?q?destroy(device=5Finfo->large.pool);=0D=0A+=09dma=5Fpool=5Fdestr?=
 =?utf-8?q?oy(device=5Finfo->small.pool);=0D=0A+=09dma=5Fpool=5Fdestroy(de?=
 =?utf-8?q?vice=5Finfo->large.pool);=0D=0A=0D=0A_#ifdef_STATS=0D=0A_=09if_?=
 =?utf-8?q?(device=5Finfo->attr=5Fres_=3D=3D_0)=0D=0A--=0D=0A2.26.0=0D=0A?=
 =?utf-8?q?=0D=0A?=
In-Reply-To: <20200327162914.24948-1-alex.dewar@gmx.co.uk>
Date:   Fri, 03 Apr 2020 17:25:06 +0100
Subject: Re: [PATCH] arm: dma-mapping: Remove unneeded NULL checks
From:   "Alex Dewar" <alex.dewar@gmx.co.uk>
To:     "Alex Dewar" <alex.dewar@gmx.co.uk>
Cc:     <alex.dewar@gmx.co.uk>, "Russell King" <linux@armlinux.org.uk>,
        "Enrico Weigelt" <info@metux.net>,
        "Allison Randal" <allison@lohutok.net>,
        "Kate Stewart" <kstewart@linuxfoundation.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Message-Id: <C1RPNOAB4OIV.1TTN7HLN0EYD@lenovo-laptop>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri Mar 27, 2020 at 4:29 PM, Alex Dewar wrote:
> dma_pool_destroy() already checks for NULL arguments, so the extra check
> is unnecessary.
>
>=20
> Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk>

Gentle ping?
> ---
> arch/arm/common/dmabounce.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>=20
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index f4b719bde763..a7c776cdc38f 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -560,10 +560,8 @@ void dmabounce_unregister_dev(struct device *dev)
> BUG();
> }
>
>=20
> - if (device_info->small.pool)
> - dma_pool_destroy(device_info->small.pool);
> - if (device_info->large.pool)
> - dma_pool_destroy(device_info->large.pool);
> + dma_pool_destroy(device_info->small.pool);
> + dma_pool_destroy(device_info->large.pool);
>
>=20
> #ifdef STATS
> if (device_info->attr_res =3D=3D 0)
> --
> 2.26.0
>
>=20
>
>=20
>
>=20