Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp731461ybb; Fri, 3 Apr 2020 10:46:10 -0700 (PDT) X-Google-Smtp-Source: APiQypK47K+np9XuV/1UTQINVXnfnEVSfDw+pgB8omJNPgqYl0yOYhdxcNAQVHG2eJcs6uTUrZxj X-Received: by 2002:a4a:d00d:: with SMTP id h13mr7658595oor.80.1585935969920; Fri, 03 Apr 2020 10:46:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585935969; cv=none; d=google.com; s=arc-20160816; b=CU22TOiraZ3lF/FOfgU8syhl538trr7KoxJnnfi5olPXbui9NCGMbG8P0N6xklZINg k7JuYyY4LF131e9BpkK+ckzVot4cCyCb7StNx0vzWRzsf2896bqdhY6K6HyHkQPH9VE4 RYFhxq9B7L83Q1ZHirn7eB4A9IBipA43KRHcDGV+l/trZwx9U9ALcPoWYXckQT5YaoRz +Q3y4oUp2/TKkRnVaRbKc6w3HFHF2w+d2qx+1jBkClOACei1lNmGTMTacmJ6H5HRFOMc UIEjZjv//cl3OLgji3DWEffC7RuDUBJ3Z63tCnCxADuhrkldnjp9s/epTjJIsdzTMa7i T5TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OaQgq0mce6nKWyunpHjd9zo5kv/FYsc1dRTanpMTsIlWMKPK8FA/JzNwk205tdUYhg cqFFSQ/Gf2WqucazNIQMBLazLVdTHCtJyXCce73ZzXgCknunOzIIn/ZruZR+UJ/EPbf2 KKzrvWFnvdQ0UNDDRgsgcHxSdC/6J2bubF24gDtlJZMyVBeTeeNBejQ66hQqRcTKS2/8 +Y/bkeVx+CjsVVoOQGN9vZckys1J5f5fxxMnp8p69/opWiqsLaPYnL2vtcnqt7Eamf/0 eqHODWq00RbnrZF/R1wD2ac1ZmmULXKwU9LByK12lgSY6vftvc6voPBOW634N2ODv1hi YtHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OrR7ulO7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si4150631otr.302.2020.04.03.10.45.57; Fri, 03 Apr 2020 10:46:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OrR7ulO7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404178AbgDCRSX (ORCPT + 99 others); Fri, 3 Apr 2020 13:18:23 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45096 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404106AbgDCRSW (ORCPT ); Fri, 3 Apr 2020 13:18:22 -0400 Received: by mail-pl1-f196.google.com with SMTP id t4so2937674plq.12 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=TdgpGqKHIFSIW7BRLxwxIKLeW1r+1xrVfvrMt/ObwuSPJTMgyvfDnjOksq191f6jaD mODqScO8h7NmTMu89d3GQg2vcEgIlxhdSQWTCsk6JSRpkjTyhm2o10+mk154cvuL+dGb 2D2iWBYdvWDnu0+CFRO8FLj6XcuQCDCtqYDyWJwNyCh0gQ/hr9pAKiCbDGoD2MzGBuOQ jwMBle00X08VElu4gAe3b05g+2GNSq1EycRhEPGYdf0HQ00EPlRDXK+tPALrmdZJFDfA ltmfmAvDELl7cwi5kXrwpvvuW2LacUM5JokDA88Geoa+2+BIbzNiTX5EMyP3CnKk5sP7 oQZg== X-Gm-Message-State: AGi0PuYoEVEOklZakRUCqsI0KNt9bk1Qrylmq2Mhen3SfTQnOPgOnN4+ 3uJaFNt7BDosReb7/O8h8vRydA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, qperret@google.com, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias