Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp778628ybb; Fri, 3 Apr 2020 11:37:59 -0700 (PDT) X-Google-Smtp-Source: APiQypI4OdfrST+L8jN6uCYhcPHKwXY2Z65+juWBMtR0X4JE2iLe+LSfxKneqzPoCaKSRRE3QQ/H X-Received: by 2002:a4a:4190:: with SMTP id x138mr7821662ooa.35.1585939079029; Fri, 03 Apr 2020 11:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585939079; cv=none; d=google.com; s=arc-20160816; b=Zv5FI+2gu92bOSYYSc9Wf1X4NBj7hQXFqcPA7jyPnK0IrMufcFQi35Y1kcTdfGBv7P CBXt1zG22oynLdJTQUI389o49MgpDo5cK/lBm7TIgrsvNEdHv7z5aB+MYzrseXAK9qd3 2psRzYjaQzBcng2GqAkhgGZJVs3Pw6O8zmGpqq0VEWWAAaBpvT2I4JNpVgweVCepZ8Gz mapZwewpzEfHqK8/jpj+vbfYLc9DX2r3u0L+c5N50rv/b6x2YmUU9+0Nt8qrb5g1TDX8 M/d7Ss7GemJiNGV3IbegfHpgv2X3pe+ZmCJtX+hPRd9Wa05BMfN2/TXrnfFMnZHvqlNO Tfdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=EFEeDaujqRyjIqNfjkZIefvUs0+yPZeeIO7lpFm3jrg=; b=YIyYtQaX4K+W4SJpoFz28vtPTTSJ7e2xuF4BaANEoJQbxqL4CaO4mgoRrLFiC5FFXc 98+0lY4iYjGWL5kJTbzinwSaqFSUnoxB9AkK2dMGtX1SZG8wHjWDMDuOMD4EfpVsA4WE awAgIMLlX0txKDExsc9wjG21d4mpie2pFEnaiBVBSxIV5ag2BwFqqM9Gw64PbVNaTEPf tAsZg9EyHQD4JOQgraJgT63yYaHd6B5J9CriI7hxXRQ1Q20lTSiKiLh2lCo8UKdDkNIN JwF0HUlqYddZNrLszK3RSTciEkic6hUkYghlG9ys/SCwQN+7RSmvtUB1mFD2RT9zOjmW Yy9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si4071266otp.314.2020.04.03.11.37.45; Fri, 03 Apr 2020 11:37:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404521AbgDCSgn (ORCPT + 99 others); Fri, 3 Apr 2020 14:36:43 -0400 Received: from mga18.intel.com ([134.134.136.126]:13440 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404320AbgDCSg3 (ORCPT ); Fri, 3 Apr 2020 14:36:29 -0400 IronPort-SDR: yEmw8XIUI0Goxgo3a4J/ktXeKufzwSyIo8mmVM1mX/7mVjOCfHv5PX6hnFoyNtwGJRAf1NC2kL w3h/9BZlUlHw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 11:36:28 -0700 IronPort-SDR: mBVonRdtUPiRgq9tEG1g6wvwsRW924NfR/JYXE1bLlE2icFZ7ruUxq7BcGn4HMyvcoKj7x3gqZ CxD3OMu1QAGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,340,1580803200"; d="scan'208";a="268439839" Received: from jacob-builder.jf.intel.com ([10.7.199.155]) by orsmga002.jf.intel.com with ESMTP; 03 Apr 2020 11:36:27 -0700 From: Jacob Pan To: "Lu Baolu" , iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Jean-Philippe Brucker , Eric Auger Cc: "Yi Liu" , "Tian, Kevin" , Raj Ashok , Alex Williamson , "Christoph Hellwig" , Jonathan Cameron , Jacob Pan , Liu@vger.kernel.org Subject: [PATCH v11 10/10] iommu/vt-d: Add custom allocator for IOASID Date: Fri, 3 Apr 2020 11:42:14 -0700 Message-Id: <1585939334-21396-11-git-send-email-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1585939334-21396-1-git-send-email-jacob.jun.pan@linux.intel.com> References: <1585939334-21396-1-git-send-email-jacob.jun.pan@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When VT-d driver runs in the guest, PASID allocation must be performed via virtual command interface. This patch registers a custom IOASID allocator which takes precedence over the default XArray based allocator. The resulting IOASID allocation will always come from the host. This ensures that PASID namespace is system- wide. Signed-off-by: Lu Baolu Signed-off-by: Liu, Yi L Signed-off-by: Jacob Pan --- drivers/iommu/intel-iommu.c | 84 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/intel-iommu.h | 2 ++ 2 files changed, 86 insertions(+) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 045c5c08d71d..ff3f0386951f 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -1732,6 +1732,9 @@ static void free_dmar_iommu(struct intel_iommu *iommu) if (ecap_prs(iommu->ecap)) intel_svm_finish_prq(iommu); } + if (ecap_vcs(iommu->ecap) && vccap_pasid(iommu->vccap)) + ioasid_unregister_allocator(&iommu->pasid_allocator); + #endif } @@ -3266,6 +3269,84 @@ static int copy_translation_tables(struct intel_iommu *iommu) return ret; } +#ifdef CONFIG_INTEL_IOMMU_SVM +static ioasid_t intel_vcmd_ioasid_alloc(ioasid_t min, ioasid_t max, void *data) +{ + struct intel_iommu *iommu = data; + ioasid_t ioasid; + + if (!iommu) + return INVALID_IOASID; + /* + * VT-d virtual command interface always uses the full 20 bit + * PASID range. Host can partition guest PASID range based on + * policies but it is out of guest's control. + */ + if (min < PASID_MIN || max > intel_pasid_max_id) + return INVALID_IOASID; + + if (vcmd_alloc_pasid(iommu, &ioasid)) + return INVALID_IOASID; + + return ioasid; +} + +static void intel_vcmd_ioasid_free(ioasid_t ioasid, void *data) +{ + struct intel_iommu *iommu = data; + + if (!iommu) + return; + /* + * Sanity check the ioasid owner is done at upper layer, e.g. VFIO + * We can only free the PASID when all the devices are unbound. + */ + if (ioasid_find(NULL, ioasid, NULL)) { + pr_alert("Cannot free active IOASID %d\n", ioasid); + return; + } + vcmd_free_pasid(iommu, ioasid); +} + +static void register_pasid_allocator(struct intel_iommu *iommu) +{ + /* + * If we are running in the host, no need for custom allocator + * in that PASIDs are allocated from the host system-wide. + */ + if (!cap_caching_mode(iommu->cap)) + return; + + if (!sm_supported(iommu)) { + pr_warn("VT-d Scalable Mode not enabled, no PASID allocation\n"); + return; + } + + /* + * Register a custom PASID allocator if we are running in a guest, + * guest PASID must be obtained via virtual command interface. + * There can be multiple vIOMMUs in each guest but only one allocator + * is active. All vIOMMU allocators will eventually be calling the same + * host allocator. + */ + if (ecap_vcs(iommu->ecap) && vccap_pasid(iommu->vccap)) { + pr_info("Register custom PASID allocator\n"); + iommu->pasid_allocator.alloc = intel_vcmd_ioasid_alloc; + iommu->pasid_allocator.free = intel_vcmd_ioasid_free; + iommu->pasid_allocator.pdata = (void *)iommu; + if (ioasid_register_allocator(&iommu->pasid_allocator)) { + pr_warn("Custom PASID allocator failed, scalable mode disabled\n"); + /* + * Disable scalable mode on this IOMMU if there + * is no custom allocator. Mixing SM capable vIOMMU + * and non-SM vIOMMU are not supported. + */ + intel_iommu_sm = 0; + } + } +} +#endif + static int __init init_dmars(void) { struct dmar_drhd_unit *drhd; @@ -3383,6 +3464,9 @@ static int __init init_dmars(void) */ for_each_active_iommu(iommu, drhd) { iommu_flush_write_buffer(iommu); +#ifdef CONFIG_INTEL_IOMMU_SVM + register_pasid_allocator(iommu); +#endif iommu_set_root_entry(iommu); iommu->flush.flush_context(iommu, 0, 0, 0, DMA_CCMD_GLOBAL_INVL); iommu->flush.flush_iotlb(iommu, 0, 0, 0, DMA_TLB_GLOBAL_FLUSH); diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index f652db3198d9..e122cb30388e 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -588,6 +589,7 @@ struct intel_iommu { #ifdef CONFIG_INTEL_IOMMU_SVM struct page_req_dsc *prq; unsigned char prq_name[16]; /* Name for PRQ interrupt */ + struct ioasid_allocator_ops pasid_allocator; /* Custom allocator for PASIDs */ #endif struct q_inval *qi; /* Queued invalidation info */ u32 *iommu_state; /* Store iommu states between suspend and resume.*/ -- 2.7.4