Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: r8CV7x0ZEMgtpnQLUnQd2siESHJnH4DW39haGHbGVbxpBil/LhwFKxfYHNK3WFyb5GoS2O2Tn2
 0pe9c9KQBlPgyrGRpRB79BYvJ3a5OCBAMOiXEfYbz5MuqK1jsJ0uR4OPm3uRJOKtuh91cU7+sR
 L+vq98mJKK4j0ejiEE6asN7rYHdi0EYOcZqZ4wkR6yfz1qDP3sskLAFCu3wCyKeOaP7WDsH+lb
 16zXfDTDg6LdprAfz53EbsIhkJmcHrlGOZp8a60RRkaWIjulXSvRTuOCB+DtgBtwSAuQngyPjr
 zN8=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Anthony Iliopoulos <ailiop@suse.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmet: add revalidation support to bdev and file backed
 namespaces
Thread-Topic: [PATCH] nvmet: add revalidation support to bdev and file backed
 namespaces
Thread-Index: AQHWCSVL06kuVSKmBEqONSGslHKI9A==
Date:   Fri, 3 Apr 2020 20:29:56 +0000
Message-ID: <BYAPR04MB49656549926DDB70C95620B986C70@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200402193052.19935-1-ailiop@suse.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 46d63de7-3c7f-4ca6-a2ca-08d7d80dc65b
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 20:29:56.9023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /YU0EkC8JZSHKBVVKt0Oo/TaJN7dH5Z1xZYpJGsiqge26cTrQ74W+u0zG2VNr3EOqFwf+wlyAn6YOWHeUNxelaq+tkzgoX/t1Cfg2ON3nco=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4296
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/02/2020 12:31 PM, Anthony Iliopoulos wrote:=0A=
> +void nvmet_file_ns_revalidate(struct nvmet_ns *ns)=0A=
> +{=0A=
> +	struct kstat stat;=0A=
> +=0A=
> +	if (!ns->file)=0A=
> +		return;=0A=
No need for the above check.=0A=
> +=0A=
> +	if (vfs_getattr(&ns->file->f_path,=0A=
> +			&stat, STATX_SIZE, AT_STATX_FORCE_SYNC))=0A=
> +		return;=0A=
=0A=
Error handling needed ? What should we set ns->size if vfs_getattr=0A=
fails ? in case of error what nvmet_identify_ns() report success or a=0A=
failure ?=0A=
> +=0A=
> +	ns->size =3D stat.size;=0A=
bdev checks the ns->size !=3D size, why the same check is not here ?=0A=
=0A=
Just remove the check from bdev and see my comment there.=0A=
> +}=0A=
=0A=