Message-ID: <440093C6.4000904@vmware.com>
Date: Sat, 25 Feb 2006 09:28:38 -0800
From: Zachary Amsden <zach@vmware.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
MIME-Version: 1.0
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ak@suse.de,
       dhecht@vmware.com, torvalds@osdl.org
Subject: Re: [PATCH] Fix topology.c location
References: <200602242305.k1ON5Tmb026520@hera.kernel.org> <20060225085538.GA17448@redhat.com>
In-Reply-To: <20060225085538.GA17448@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 672
Lines: 18

Dave Jones wrote:

>This change breaks x86-64 compiles, as it uses the same file.
>  
>

Thanks for fixing that.  Have we decided that file sharing of this sort 
is a really bad idea yet?  I still see early_printk and  pci-direct.h 
sharing remains.  If this sharing really must go on, isn't there a less 
ad-hoc way to do it?  Or at least a mention in the file that "before you 
modify, note this is shared by arch foo".

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/