Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp999732ybb; Fri, 3 Apr 2020 16:07:36 -0700 (PDT) X-Google-Smtp-Source: APiQypIs+E8C2Hs6//3AcE3CkAT9m3tOQy7bBOVKLkC0K2CeL0AvO20SBPe3tdJx+WxX4fdjVzxY X-Received: by 2002:aca:56c7:: with SMTP id k190mr5050437oib.127.1585955256362; Fri, 03 Apr 2020 16:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585955256; cv=none; d=google.com; s=arc-20160816; b=F8JqcppN067h1BgxlMMhzzFdr6iz3NXjTkNpsR5ZSbUXMVGgivOK27f2zu7yme9xfs WcxPwkFZTNcBomUiUGZ453dNUuHONlUQPKrWT1/tk7wcLIaRWvIq4kEpoO5z2PqWtBrq SvJ/pOOqKDpcbvXR6yRseedVHsOzZvUy9faI7pukk1Z7Bsre55S4v0rsPd1aCrRH1f7k V8MdCjvzM966YfipPwhXn6GmtwcYJnDRawk8POPEkoObNGkbrNLbvmAg5oUZ/f71oDeQ VxTP2Y1faISsJwo498hZtKQg7R0A2rxJmEeEtCJ3ljbx8ZIK/mc5UQGIP8UKU0oL6k1+ S+dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Zjstre6xnKRkncSVS6O9eLE48QBraPkkHOFYRm926gY=; b=YZ30ynicB//W4AgurT+QPZUjd7HBdXVhKpTH3QFTWeRisF0MZau5g1Dn9qL+gf80Cp s7rWWAZe0EBDKbDOSOfMV8LxOMxe3pdeC0UAbFIhAK+K0aVu1Wz1vG3Y3o/50IW9IwWn lFcbkAfkXzr9s/272UuaqfTzCauZ8OV09nnz8PIJGT8z80BIXGDGxB7dpir2FrtaztQr EaP/W7giattUuF2fuqfmcqI4ltbWXSJ8kjEPpeIVxX3MjTfhxFbfraXofRcP6x3vrha/ 9SNo4SFiwQjf72SmVol5drled0DjQbAEomfR7cMrWti9RcPiKrogycDkDB1n0caXkaMh Vo/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si4890030otk.62.2020.04.03.16.07.23; Fri, 03 Apr 2020 16:07:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728728AbgDCXGu (ORCPT + 99 others); Fri, 3 Apr 2020 19:06:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36372 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbgDCXGu (ORCPT ); Fri, 3 Apr 2020 19:06:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D6F7D121938E3; Fri, 3 Apr 2020 16:06:49 -0700 (PDT) Date: Fri, 03 Apr 2020 16:06:49 -0700 (PDT) Message-Id: <20200403.160649.1243854856424851277.davem@davemloft.net> To: geliangtang@gmail.com Cc: mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net, kuba@kernel.org, netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mptcp: add some missing pr_fmt defines From: David Miller In-Reply-To: References: <34c83a5fe561739c7b85a3c4959eb44c3155d075.1585899578.git.geliangtang@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 Apr 2020 16:06:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geliang Tang Date: Fri, 3 Apr 2020 17:14:08 +0800 > Some of the mptcp logs didn't print out the format string: > > [ 185.651493] DSS > [ 185.651494] data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1 > [ 185.651494] data_ack=13792750332298763796 > [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=0 skb=0000000063dc595d > [ 185.651495] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 status=0 > [ 185.651495] MPTCP: msk ack_seq=9bbc894565aa2f9a subflow ack_seq=9bbc894565aa2f9a > [ 185.651496] MPTCP: msk=00000000c4b81cfc ssk=000000009743af53 data_avail=1 skb=0000000012e809e1 > > So this patch added these missing pr_fmt defines. Then we can get the same > format string "MPTCP" in all mptcp logs like this: > > [ 142.795829] MPTCP: DSS > [ 142.795829] MPTCP: data_fin=0 dsn64=0 use_map=0 ack64=1 use_ack=1 > [ 142.795829] MPTCP: data_ack=8089704603109242421 > [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=0 skb=00000000d5f230df > [ 142.795830] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 status=0 > [ 142.795831] MPTCP: msk ack_seq=66790290f1199d9b subflow ack_seq=66790290f1199d9b > [ 142.795831] MPTCP: msk=00000000133a24e0 ssk=000000002e508c64 data_avail=1 skb=00000000de5aca2e > > Signed-off-by: Geliang Tang Applied, thanks.