Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200402142747.8307-1-daniel.lezcano@linaro.org> <20200402142747.8307-5-daniel.lezcano@linaro.org>
In-Reply-To: <20200402142747.8307-5-daniel.lezcano@linaro.org>
From:   Amit Kucheria <amit.kucheria@verdurent.com>
Date:   Sat, 4 Apr 2020 13:00:00 +0530
Message-ID: <CAHLCerMVSAtzBc2eRn5Mokyo4qnwX33ux9dFBuoJXzSQbNJL1A@mail.gmail.com>
Subject: Re: [PATCH V2 5/9] thermal: Move get_tz_trend to the internal header
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Zhang Rui <rui.zhang@intel.com>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> The function is not used any place other than the thermal
> directory. It does not make sense to export its definition in the
> global header as there is no use of it.
>
> Move the definition to the internal header and allow better
> self-encapsulation.
>
> Take the opportunity to add the parameter names to make checkpatch
> happy and remove the pointless stubs.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  drivers/thermal/thermal_core.h | 2 ++
>  include/linux/thermal.h        | 4 +---
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index d37de708c28a..5fb2bd9c7034 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -72,6 +72,8 @@ struct thermal_trip {
>         enum thermal_trip_type type;
>  };
>
> +int get_tz_trend(struct thermal_zone_device *tz, int trip);
> +
>  /*
>   * This structure is used to describe the behavior of
>   * a certain cooling device on a certain trip point
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 7adbfe092281..8006ba5de855 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -414,7 +414,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);
>  int thermal_zone_get_slope(struct thermal_zone_device *tz);
>  int thermal_zone_get_offset(struct thermal_zone_device *tz);
>
> -int get_tz_trend(struct thermal_zone_device *, int);
>  struct thermal_instance *get_thermal_instance(struct thermal_zone_device *,
>                 struct thermal_cooling_device *, int);
>  void thermal_cdev_update(struct thermal_cooling_device *);
> @@ -473,8 +472,7 @@ static inline int thermal_zone_get_slope(
>  static inline int thermal_zone_get_offset(
>                 struct thermal_zone_device *tz)
>  { return -ENODEV; }
> -static inline int get_tz_trend(struct thermal_zone_device *tz, int trip)
> -{ return -ENODEV; }
> +
>  static inline struct thermal_instance *
>  get_thermal_instance(struct thermal_zone_device *tz,
>         struct thermal_cooling_device *cdev, int trip)
> --
> 2.17.1
>