Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1365657ybb; Sat, 4 Apr 2020 02:25:15 -0700 (PDT) X-Google-Smtp-Source: APiQypKnRZmTUgr1LD/iuJS6C4BBZEOrgChrpRNB3VJudpyL7NyRjFSV7XTDiqPEUYSkd+jymOQJ X-Received: by 2002:a9d:748a:: with SMTP id t10mr10491546otk.244.1585992315526; Sat, 04 Apr 2020 02:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585992315; cv=none; d=google.com; s=arc-20160816; b=tZ1vDfsd9/Tpmm/qXEB0DSxU1DgoLr/6+wpACvBmGM+C9/QsAIZbO9IaOUa8iFYuak HX3jlYfw7pLBmTIS5P+aQsjYRa6SqxLZ184EgRS9JneiECMjc9X0HBp4HCyoWUjuerlS DdiztDDU6vmCeyI/6fqQERQuzNi4JM1AQl4sRaUlJdCgpO5JwWiQE/juYktiB7aO4II8 z38bU/biaTORQfroRLGrn7G01fAHmXh3f/ui+d0jA7sL/0tuhmDy/hYvgMJvPb/+aa7v J11JwCQoMDVRb/3iwp+Lwh4imewjUVFE+t1Y7rU+zYluU7LHIBqm2v9qfHHIx0BmY7Qf AtpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YNE5OyX0sIdVscEAE36o1ZYd2RN3W+73Recc12rRc3I=; b=fAqH2QeX+Ye40kQKJkX5Z96Nx8sCZ2o5rvJYH6BWpyrmCAX/KXRu7pa+q/EERgDzYO s0FEN7wYzMcbPnO0Fo0x1F0NpveojxO5YguTeU2T+cgy65NfdYHUh/jiHFGb/56qtXxm 2V6p2ygnFdRFNyMRHDxOpKkiyiLKah31cxoG+S62QPCu+xXAeimXQsxv6nz7x/g72Jea Mg1By+6T9IJwB/2M2IEmTZcM4pPdTHDk9fQhyy5uKwOmJ5eHflQtVhUO2HntbAsqBLQt CqLNRdomu/JjJ3iaMEoj9fvlbJe7Wym3pv6ZjH6C5J2ee9aEeLyWw7exJ1UnEUvyF50W X0sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yWURUNjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si5220406oom.72.2020.04.04.02.25.03; Sat, 04 Apr 2020 02:25:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yWURUNjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgDDJXO (ORCPT + 99 others); Sat, 4 Apr 2020 05:23:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgDDJXO (ORCPT ); Sat, 4 Apr 2020 05:23:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 560A720719; Sat, 4 Apr 2020 09:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585992192; bh=UugXHomrGMjeaRYQYJLHjXdfqAsEeVXQa5Ng6EM0r5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yWURUNjFaeHvQQ/R6RNuQ39Te/lVsOuy3a9WytDhxZXtvo8CNRp7lPS0n23w3NFy6 8FJ/DZTG6L/BOWmfFDCYAah6m7PB7TFcVXBmJ9BlA4UAYojUt8q7oaH8LQXbs+8Nll krjMmOS0fcqK4V5uqFlpjg7V4lkN1b0AcN6w+5kQ= Date: Sat, 4 Apr 2020 11:23:08 +0200 From: Greg KH To: madhuparnabhowmik10@gmail.com Cc: hariprasad.kelam@gmail.com, colin.king@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, andrianov@ispras.ru, stern@rowland.harvard.edu Subject: Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list and list head u132_list Message-ID: <20200404092308.GB1110038@kroah.com> References: <20200403181816.8115-1-madhuparnabhowmik10@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200403181816.8115-1-madhuparnabhowmik10@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 03, 2020 at 11:48:16PM +0530, madhuparnabhowmik10@gmail.com wrote: > From: Madhuparna Bhowmik > > u132_static_list is a global list protected by u132_module_lock. > It is read in the u132_hcd_exit() function without holding the lock > thus may lead to data race. > However, it turns out that this list isn't used for anything useful > and thus it is okay to get rid of it. > Thus, remove the u132_static_list from u132-hcd module. > Also remove struct list_head u132_list from struct u132. > > Found by Linux Driver Verification project (linuxtesting.org). > > Suggested-by: Alan Stern > Signed-off-by: Madhuparna Bhowmik > --- > drivers/usb/host/u132-hcd.c | 10 ---------- > 1 file changed, 10 deletions(-) Please properly version your patches, otherwise I have no idea what changed from the previous one, nor do I know which patch to take over which. The instructions for how to do this is in the documentation. Please fix up and resend so I have a chance to know what to do... thanks, greg k-h