Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1471764ybb; Sat, 4 Apr 2020 05:07:18 -0700 (PDT) X-Google-Smtp-Source: APiQypLciqXICaVq1IqVF9SVEJLsAKEt+TccdQLwHl0Bls5yj43bu9SzgKFBXRooUQIVWZney1fL X-Received: by 2002:a05:6830:239b:: with SMTP id l27mr10345413ots.278.1586002038480; Sat, 04 Apr 2020 05:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586002038; cv=none; d=google.com; s=arc-20160816; b=0EHaYn0hba1e+2Yzex8V0HRLw+MOz1UA8fIAICCCdW+lDOvYLDggy4HcuF7TXFGWRR Q1YyNLGGxTZuDe3q0InCrRRtv5aj9mBYDe8marSVj+PEZ0UjyvT3MEkamwiNl5wDQvZm +ekjWDLZG5L/hpl0yyS0NR9mKJV0lwdC1ZLnFfcAB8CuE4sUUzwrjyk2oIZ8UOvYBCCe wUFXzGiggeOIz/Is6ZruGTY2clS1D7qdOxhg5ifYb9KFwAw7eQSVOBm141I+XHvy2BDl oVdLKVuL+A4peKt3DOlW+Tsd6bu7z0o/SHZYP185V84O2FdsOpmGnGKOa9aoA63F2aQn Zj9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=QYJZYm/TZtPYH2Uo92Cj0VFecD+oownSX2E0rX/K7J8=; b=reRGsB6er5LIphpwCNhpFIuTiwJIitqEGOeL5BMxte1EakQ4ce3c2JIhHv+hkrqYW5 DjQEceVhZILQnKUiBeT/X3mFHUmgUamJf7lm5IweYi9MV/VzQmSfnRNzMNUZBpxvKcou KqdvdwjcA7EYgTD/82eziW37MtX1PQvM6xIaxcLnB0aMKeyNjetxv3A9denbSWXzaDbr /bWHgjN+MlV0kYEzJjD+HLR+seyvtAQRbylRKU61Wrdli6NDqy9nfShUHWgg/re17YC2 4PXPnqxdH1owY+GJTuJNGoZH7WU3VEOyCXsjbbDGPiR8809Wy3kHBD6VO65jmV0peGZ4 S+hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y123si4995588oia.141.2020.04.04.05.07.05; Sat, 04 Apr 2020 05:07:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726220AbgDDMGu (ORCPT + 99 others); Sat, 4 Apr 2020 08:06:50 -0400 Received: from [106.54.107.2] ([106.54.107.2]:56984 "EHLO mail.kaowomen.cn" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgDDMGu (ORCPT ); Sat, 4 Apr 2020 08:06:50 -0400 X-Greylist: delayed 513 seconds by postgrey-1.27 at vger.kernel.org; Sat, 04 Apr 2020 08:06:47 EDT Received: by mail.kaowomen.cn (Postfix, from userid 1001) id E863841329; Sat, 4 Apr 2020 19:57:59 +0800 (CST) Date: Sat, 4 Apr 2020 19:57:59 +0800 From: Bo YU To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yuzibode@126.com, tsu.yubo@gmail.com Subject: [PATCH -next] block/genhd: Align the label with the content of the /proc/partitions Message-ID: <20200404115759.yo4u52vdzsvox6wc@kaowomen.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before the patch,cat /proc/partitions: major minor #blocks name 254 0 57671680 vda 254 1 57670656 vda1 After the patch: major minor #blocks name 254 0 57671680 vda 254 1 57670656 vda1 According to LDD3,major device maximun number is 12 bit,as it has 4 char placeholders.minor device maximum number is 20 bit(7 char palceholders) and keeping 10 char palceholders for blocks tag.If want to keep palceholder's numbers dynamiclly, There is more tricks to do that. So i keep it simple. Signed-off-by: Bo YU --- block/genhd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 06b642b23a07..63a483cf76b9 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1151,7 +1151,7 @@ static void *show_partition_start(struct seq_file *seqf, loff_t *pos) p = disk_seqf_start(seqf, pos); if (!IS_ERR_OR_NULL(p) && !*pos) - seq_puts(seqf, "major minor #blocks name\n\n"); + seq_puts(seqf, "major minor #blocks name\n\n"); return p; } @@ -1172,7 +1172,7 @@ static int show_partition(struct seq_file *seqf, void *v) /* show the full disk and all non-0 size partitions of it */ disk_part_iter_init(&piter, sgp, DISK_PITER_INCL_PART0); while ((part = disk_part_iter_next(&piter))) - seq_printf(seqf, "%4d %7d %10llu %s\n", + seq_printf(seqf, "%-4d %-7d %-10llu %s\n", MAJOR(part_devt(part)), MINOR(part_devt(part)), (unsigned long long)part_nr_sects_read(part) >> 1, disk_name(sgp, part->partno, buf)); -- 2.11.0