Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 4 Apr 2020 16:01:27 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Guido =?UTF-8?B?R8O8bnRoZXI=?= <agx@sigxcpu.org>,
        Tomas Novotny <tomas@novotny.cz>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "Angus Ainslie (Purism)" <angus@akkea.ca>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Nishant Malpani <nish.malpani25@gmail.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add
 near-level
Message-ID: <20200404160127.1ef9d1ac@archlinux>
In-Reply-To: <20200331214517.GA24128@bogus>
References: <cover.1585134362.git.agx@sigxcpu.org>
        <f0ad40351d7ab12f79d2c29f738443514ae0fb76.1585134362.git.agx@sigxcpu.org>
        <20200329102526.1ee85e96@archlinux>
        <20200331214517.GA24128@bogus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 31 Mar 2020 15:45:17 -0600
Rob Herring <robh@kernel.org> wrote:

> On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> > On Wed, 25 Mar 2020 12:09:06 +0100
> > Guido G=C3=BCnther <agx@sigxcpu.org> wrote:
> >  =20
> > > This value indicates when userspace should consider an object
> > > near to the sensor/device.
> > >=20
> > > Signed-off-by: Guido G=C3=BCnther <agx@sigxcpu.org> =20
> >=20
> > I'm fine with this.  Note for Rob or other DT people.
> >=20
> > This is a new generic binding hence no vendor prefix. =20
>=20
> Then document in a common place.

Ok.=20

I guess we need to create a proximity specific binding file.

Documentation/devicetree/bindings/iio/proximity.yaml

Guido, could you do a v4 adding such a file.  For now I think
this is pretty much all that is proximity specific.

At somepoint we should convert the subsystem wide iio-bindings.txt
but not today!

Thanks,

Jonathan

>=20
> >=20
> > I will ideally want review of both the dt patches though
> > before applying.  As we've missed the merge window anyway
> > there is no particular rush.
> >=20
> > Thanks,
> >=20
> > Jonathan
> >  =20
> > > ---
> > >  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml    | 8 ++++++=
++
> > >  1 file changed, 8 insertions(+)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4=
000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > @@ -25,6 +25,13 @@ properties:
> > >    reg:
> > >      maxItems: 1
> > > =20
> > > +  near-level: =20
>=20
> Perhaps proximity-near-level instead.

Makes sense.

>=20
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    description:
> > > +      Raw proximity values equal or above this level should be
> > > +      considered 'near' to the device (an object is near to the
> > > +      sensor).
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -40,6 +47,7 @@ examples:
> > >        light-sensor@51 {
> > >                compatible =3D "vishay,vcnl4200";
> > >                reg =3D <0x51>;
> > > +              near-level =3D <220>;
> > >        };
> > >    };
> > >  ... =20
> >  =20