Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1628381ybb; Sat, 4 Apr 2020 08:37:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJwbh749U4xugFEIzlbYltLtV/8q6VW5GSmwRm7PGJWa6NFx34jyyIEHSdrRA6c5JOAPfFS X-Received: by 2002:aca:4991:: with SMTP id w139mr7095593oia.145.1586014637232; Sat, 04 Apr 2020 08:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586014637; cv=none; d=google.com; s=arc-20160816; b=O7q7f2qlHDz4ZjismlZ2Kqyf+aK1p8Rbon8STK/A4dU4aNS2tgA596d1Ea6ruWjFT3 b8gDAat1/nk8gXJ4Ydhb0ImSUEZv+TStbYNKlhYd6PRvZTOe7ry/wJmsqIQKhcjBquld OoCFUtSCoCEEP9PxW/VMSME2/r7OCqxaHjrJUdoA7HDAsFZKjqFjBO2UcwYR4aFmVOqX D6QaTuRP/G87UgvMJxARMBzju633tvjC4M6bj4xJ4ftDRBm4XajpR+3UOw4nU+DR/bHJ ndDkgTpD5Y/v7eIq97GdZtZuJyLmurfkke3lJVReLUWn/HS66VHl5Y0whF1BJoPt4rIJ J/2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:cc:date:message-id:subject :mime-version:from:content-transfer-encoding:dkim-signature; bh=DLf2vhWBRYv3EPu/oUxKTRyjQV56vIPOgQY2nOhxbP0=; b=FirI44ec71iypeWGEmPUM3JZ/vyzvIZjDpodvUxivejlMET3nGq9ST4Ib8EM9AcSNn CF4oh1GSYq/VSAUaU8NqXjsR1U+C7Tv324zxl8WcaMOJ1od86YN0qTV80lnlbg5Ebkgy U/dmuMPyN/eK73HYZyQtLQaEcH7f/AkKFa8y74kY37r2oywQXPFdXWgeQhdhglAkwz1J MFmfVcqLSKBkbS8iyIPah+gkYtrzRewhmauRPp1gQOFDJiIY10v+xlRGrU0t7kBSIMcP AxuYFm/HW/ybahAJzeIS1DhurOyZ8WPINBfuOTyqLYNpY4OyZPDJbgw1+UYZnZBL+TUP HQuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=WslufRIL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t13si5159488otp.249.2020.04.04.08.36.59; Sat, 04 Apr 2020 08:37:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=WslufRIL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbgDDPfm (ORCPT + 99 others); Sat, 4 Apr 2020 11:35:42 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:47262 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgDDPfl (ORCPT ); Sat, 4 Apr 2020 11:35:41 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 034FRsCm040152; Sat, 4 Apr 2020 15:35:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : content-transfer-encoding : from : mime-version : subject : message-id : date : cc : to; s=corp-2020-01-29; bh=DLf2vhWBRYv3EPu/oUxKTRyjQV56vIPOgQY2nOhxbP0=; b=WslufRIL4441F25A+QBTCYAvUFxpAc0TRPSF1dIj+BChAWs6c2cO2rQ4nUHDth3qjSU6 O5NOJIubS+o1Ir+rPaKDuezDh+zlpd9WF3stAb70LdJ7ZZLrL0H4sZ40wwQLc7NMgOw4 mo8V7c3Yfd0B6zKvkRrZFAbDPvLpnxf7eswqn8Ggx2sM+nugQZe3dwJU1qtYbVNICu6T 6suba0EPMWOc/GSq7/+Df5dCk1tkdhl+Xu68FXEvcornLYFH7aSV8Xz0j7GBLeq9iBWr dtuy8K20p41vkntWsmnlc8bLYZh0V/1DTFyUp+t+ilNU44qglD/ZmYFnsNCDcZleKJO0 yg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 306j6m1650-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 04 Apr 2020 15:35:07 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 034FRG0e100081; Sat, 4 Apr 2020 15:35:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 306j21fub1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 04 Apr 2020 15:35:06 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 034FZ4nb019828; Sat, 4 Apr 2020 15:35:04 GMT Received: from [10.0.0.106] (/76.25.178.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 04 Apr 2020 08:35:04 -0700 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: William Kucharski Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-Id: Date: Sat, 4 Apr 2020 09:35:02 -0600 Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, jroedel@suse.de, vbabka@suse.cz, urezki@gmail.com, Thomas Gleixner To: Peter Zijlstra X-Mailer: iPhone Mail (17F5034c) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9581 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=582 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004040145 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9581 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=659 spamscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 mlxscore=0 phishscore=0 adultscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004040145 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =EF=BB=BFIs there any need to similarly sanitize =E2=80=9Csize=E2=80=9D to a= ssure start + size doesn=E2=80=99t go past =E2=80=9Cend?=E2=80=9D > On Apr 3, 2020, at 10:33, Peter Zijlstra wrote: >=20 > =EF=BB=BF > __get_vm_area() is an exported symbol, make sure the callers stay in > the expected memory range. When calling this function with memory > ranges outside of the VMALLOC range *bad* things can happen.