Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200320094233.GA30959@localhost.localdomain> <CAL_JsqJjLGz6LPQmTP5eJTdti38yQa86UWiwCTae81Fr7eMHtA@mail.gmail.com>
In-Reply-To: <CAL_JsqJjLGz6LPQmTP5eJTdti38yQa86UWiwCTae81Fr7eMHtA@mail.gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Sat, 4 Apr 2020 11:30:35 -0600
Message-ID: <CAL_JsqJ2VBDHSWViyvjEBckOqsMQVUdOGjABH0AT6LiaMnJx1Q@mail.gmail.com>
Subject: Re: [RESEND PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850
To:     Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 4, 2020 at 11:28 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Mar 20, 2020 at 3:42 AM Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com> wrote:
> >
> > Convert ROHM bd71837 and bd71847 PMIC binding text docs to yaml. Split
> > the binding document to two separate documents (own documents for BD71837
> > and BD71847) as they have different amount of regulators. This way we can
> > better enforce the node name check for regulators. ROHM is also providing
> > BD71850 - which is almost identical to BD71847 - main difference is some
> > initial regulator states. The BD71850 can be driven by same driver and it
> > has same buck/LDO setup as BD71847 - add it to BD71847 binding document and
> > introduce compatible for it.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> I did, but there's some dtc warnings that need to be fixed:
>
> Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dts:23.17-30:
> Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has invalid
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (pci_device_reg): Failed prerequisite 'reg_format'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dts:20.13-131.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for
> I2C bus
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dts:20.13-131.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
> I2C bus
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dts:21.25-130.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #address-cells value
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dts:21.25-130.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #size-cells value
>  Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.example.dt.yaml:
> Warning (unique_unit_address): Failed prerequisite
> 'avoid_default_addr_size'

And also:

Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dts:23.17-30:
Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dts:20.13-112.11:
Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for
I2C bus
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dts:20.13-112.11:
Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
I2C bus
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dts:21.25-111.15:
Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
default #address-cells value
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dts:21.25-111.15:
Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
default #size-cells value
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.example.dt.yaml:
Warning (unique_unit_address): Failed prerequisite
'avoid_default_addr_size'