Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1762174ybb; Sat, 4 Apr 2020 11:53:15 -0700 (PDT) X-Google-Smtp-Source: APiQypLF4eQ6ep2tMO2OV26t6qDR97+3mOB0qwnvOYZ4TwIIOmp/an3e0Y2JHtDV1HE7LtOHYe0/ X-Received: by 2002:a4a:d30c:: with SMTP id g12mr11298499oos.16.1586026395436; Sat, 04 Apr 2020 11:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586026395; cv=none; d=google.com; s=arc-20160816; b=lFZ6ADfgubKw0V6f/OfxmDnNUytSM7MQ1W7h18LUt6RC9le3ieSrxYDCyVIy4LwNxP JgmLIjP1c/L0cR5oQGHKkEtiQKeffxlZzT/ye6FogCiBY8irAotTmFbSeGs5nKZlWaAd EOyzzBxIO1F4Yr3x+W+Qp5zbCWG1vCr5VR8UnT96+OLDZpxypUTOnhg2Br4w6skzkviO P/q1ywBtbJgUJGi+MUuJCc7w+8/k9vpDVIzkYmht8N7MfANTDAM0xJNCnqv2kU30f6Lm Nj8N5wOE6wbHX08XWZX9mBpjnj3i+UWEBfjlGnGc2FDhodj9lb7+u1DxcHpS0D2lbrfa NDSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:date:from:dkim-signature; bh=hBMXqhkR3Bd5JwVi0rinAAJBGM9rUC/9TzS2AavdsaE=; b=KMwdv0YPF6XlI0eVBl4L0JLJDF68fW8/pcCDNEhhCoczFf0I0rAzQ7eQVm9fXT+I7t g5QmDi3XgIcfjHIT6oHVk//zhXJaINKNMMcWHKtntZzTl5eYzeiM3RCGajnAawitgz6+ fW2ivzJKiM4b5R0S4+XaUoTX3DZgw4ZfdbZerWyvEMLiIbZ1SwN4pOwdLlcVaZhNGt1N sKi8finvfhgH6cIjVvFSw6GE1tUHDM2Aw0uBlXeUhQNTWzcxf6dAHPLonAciS8ab8daz 0ub5OEh3BYJHDS+89UULq1gl1eVZBEsx4WA85eIxCJLPE0A99qM1rYLg4KXqJvC1yeg0 9dlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eEawZWJ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a128si5320497oif.202.2020.04.04.11.53.01; Sat, 04 Apr 2020 11:53:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eEawZWJ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgDDSwj (ORCPT + 99 others); Sat, 4 Apr 2020 14:52:39 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:33427 "EHLO mail-lj1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbgDDSwj (ORCPT ); Sat, 4 Apr 2020 14:52:39 -0400 Received: by mail-lj1-f171.google.com with SMTP id f20so10431289ljm.0 for ; Sat, 04 Apr 2020 11:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hBMXqhkR3Bd5JwVi0rinAAJBGM9rUC/9TzS2AavdsaE=; b=eEawZWJ2ayk08oPbswgZWuozx6Ijh+Ywg9oScIkGbDjhxGyhf1oVbDqIqrcTpJA988 a1q6xo0g9jvs8M6iIEvzHndqLyuf7sQN8764oNTZJK8P+OPFviBgefcAKYHY8JAmq2zV SpxyQ1rpaZK0RZUGG1neWz9nlbgANMmhF/ns9775kmnWxwzWpE0GA76KeatKo1UgD45o AXo9A2vijGJ8uCiaUrPZ/DPZoBO6y3xTWQvtTpzioRnl7ZGSZMqHQIgjSChGb2xIkAtK suUFx3iJG+ohi+AkhWjqQ+LmLNq7yYGaJ952fAUgiWDKq/6F6JgaxHQflI37oeFP1/I9 PoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hBMXqhkR3Bd5JwVi0rinAAJBGM9rUC/9TzS2AavdsaE=; b=KFkA6pyTD1LAqXNSdeUaAEdKVHZSIFnlNyPMB55JnzurK020qvJjM1xy8HHkwFmReK 0RUlPthVbkNmGI0iNAyE5OHZ/wpUY5fJLmzyoIv4hiWF1wGkLqTrGr43aOfi8UvCIq55 mU8uBL92RKOD3S1gWtgOWxlfhEkrArsSPuxia2jiaLAQMj3145MMPOnc6usttfmjITOU gRVv8wPBKC9ZC4tGj+FZTbiN92nZW4X/nqMmz9WuDYvfkiNMUr5sAvF1Ts92sBMYnqKJ K+XcqSY+cXlBg5r91FLK2eIx/2OMz370zeluYiqeNpf0AJD8X/svWKHCmKpyy0l8B+p2 Knqw== X-Gm-Message-State: AGi0PuaJ4r3jBDi+e4auCQJ8aejyGddLSWXOi8ELpLYAkF+WGdEouUBi wCho7weRp5im0uPRXZzvagA= X-Received: by 2002:a2e:998c:: with SMTP id w12mr8197378lji.57.1586026357027; Sat, 04 Apr 2020 11:52:37 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id o2sm7293546ljm.2.2020.04.04.11.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2020 11:52:36 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 4 Apr 2020 20:52:29 +0200 To: William Kucharski Cc: Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, jroedel@suse.de, vbabka@suse.cz, urezki@gmail.com, Thomas Gleixner Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-ID: <20200404185229.GA424@pc636> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Is there any need to similarly sanitize “size” to assure start + size doesn’t go past “end?” > Why is that double check needed if all such tests are done deeper on stack? -- Vlad Rezki