Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2232822ybb; Sun, 5 Apr 2020 02:15:37 -0700 (PDT) X-Google-Smtp-Source: APiQypJFFBNCi4Dg4fbADbu6y0+zI74f0YDOZGCriCAwjcWjhoXahknMg/Ep/lxIcLeqInFBt/Do X-Received: by 2002:aca:5508:: with SMTP id j8mr9303345oib.71.1586078136900; Sun, 05 Apr 2020 02:15:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586078136; cv=none; d=google.com; s=arc-20160816; b=QDAAYCSxPOgfUIpIESCgenfqX2QoTff4aKv4sUf1JOM3VEUYmzGQ0E3ITaDLG6V3iE B9dU1dzcxsLM6PvWRZcBzNvinBHQeAv7kwuHZa68U6NipHwtPWksmCkm83zlrPqUKQNJ toOx2geemmckVUUeCQzy7hV+okjmwUmnlwbX26q0zGG+WyauxYBSBB8da3020I8qrLuW KtW5YqBl30kLnLwVg2c86lfsu3nGVKSN33W8d22qxweV5q5mvOepmTEhcs3URwaLuwWx fAsB2GcOBBWKU7P4zjXUlo7/9hTxDzxhpPxR+XI9uFsl/tthIu4dbJ9CLF2pd58C2o6+ 8xtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=6/9MibweBRdexKNq6gs4nfntQ4hl08uFrMqjxWvBPlM=; b=tBUK0WLbiBaTscvvmnvG3nZ1FM9Q5EeuCyqodCHHA7+NVbtt+lOPC2X9n9hMUIbpbI 9MOjNpyNb7mL9gz1Jjxpk/aPaXCMWFw+W4N3AbsNycUQ22Uzd930lY9wp/gkC7068etb UNkJ/TMHL0eyIEqOp7CyhgzSzPm6t8aacJktGcNva6tLz4BMOz/GwOKV6xhRLstTFNhK wgP7SgW84ih2sk11ii6L82dfF0NAgFssykLz+++QBf1XQivguR/f065iU+5MSBRq9TiZ L/ejQoIcWSz+8dzeWEO1Klilt43NgEFLkXlY9g7Ss9hiL4NZYXJJxYEr0rwTJjzAE3xM TrQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GbrH2OrB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e53si6375820ote.156.2020.04.05.02.15.23; Sun, 05 Apr 2020 02:15:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GbrH2OrB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbgDEJOp (ORCPT + 99 others); Sun, 5 Apr 2020 05:14:45 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:62300 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726308AbgDEJOo (ORCPT ); Sun, 5 Apr 2020 05:14:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586078084; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=6/9MibweBRdexKNq6gs4nfntQ4hl08uFrMqjxWvBPlM=; b=GbrH2OrBe5qxu9dN3zBhvArSYuvWWlYOr3YqMeypOFbwVtY91BDQH+56n+45TH//6ASAhy+Z e3EnaGq5zYtlrgQcbdoz7ehbBtvNnhBOea1jgVnM8idLeFlj3liR9a4qexrrueZCmDHcA8F8 qQKOvQNsW6n9NLyzEr7VaLuNnK4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e89a179.7f1fa20ed2d0-smtp-out-n05; Sun, 05 Apr 2020 09:14:33 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1A7E1C433D2; Sun, 5 Apr 2020 09:14:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 79925C433D2; Sun, 5 Apr 2020 09:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 79925C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Luca Coelho Cc: Chris Rorvick , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" Subject: Re: [PATCH] iwlwifi: actually check allocated conf_tlv pointer References: <20200402050219.4842-1-chris@rorvick.com> <87mu7qfhiy.fsf@codeaurora.org> Date: Sun, 05 Apr 2020 12:13:55 +0300 In-Reply-To: (Luca Coelho's message of "Sun, 05 Apr 2020 11:51:53 +0300") Message-ID: <87zhbqz44s.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luca Coelho writes: > On Sun, 2020-04-05 at 11:44 +0300, Kalle Valo wrote: >> Chris Rorvick writes: >> >> > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating >> > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e >> > ("iwlwifi: dbg: move debug data to a struct") but does not implement the >> > check correctly. >> > >> > Tweeted-by: @grsecurity >> > Signed-off-by: Chris Rorvick >> >> I'll add: >> >> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") >> >> > --- >> > In this wasn't picked up? >> >> Luca, can I take this directly? > > Yes, please take it directly. Ok, assigned it to me in patchwork. > This can happen in OOM situations and, when it does, we will > potentially try to dereference a NULL pointer. I'll add this to the commit log. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches