Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] powerpc/powernv: add NULL check after kzalloc in
 opal_add_one_export
To:     Qiujun Huang <hqjagain@gmail.com>, benh@kernel.crashing.org,
        paulus@samba.org, mpe@ellerman.id.a, tglx@linutronix.de
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20200405075123.28756-1-hqjagain@gmail.com>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <99de2220-5a64-e81e-6886-447296431548@c-s.fr>
Date:   Sun, 5 Apr 2020 12:13:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200405075123.28756-1-hqjagain@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 05/04/2020 à 09:51, Qiujun Huang a écrit :
> Here needs a NULL check.
> 
> Issue found by coccinelle.
> 
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
>   arch/powerpc/platforms/powernv/opal.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 2b3dfd0b6cdd..09443ae3a86e 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -811,6 +811,11 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
>   		goto out;
>   
>   	attr = kzalloc(sizeof(*attr), GFP_KERNEL);
> +	if (!attr) {
> +		rc = -ENOMEM;
> +		goto out;

You don't need to go to out:, there is nothing to do. You should do:

	if (!attr)
		return -ENOMEM;

> +	}
> +
>   	name = kstrdup(export_name, GFP_KERNEL);
>   	if (!name) {
>   		rc = -ENOMEM;
> 

Christophe