Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200405075123.28756-1-hqjagain@gmail.com> <99de2220-5a64-e81e-6886-447296431548@c-s.fr>
In-Reply-To: <99de2220-5a64-e81e-6886-447296431548@c-s.fr>
From:   Qiujun Huang <hqjagain@gmail.com>
Date:   Sun, 5 Apr 2020 18:21:49 +0800
Message-ID: <CAJRQjodoHMn+XA+iYkM2D8OiEWk1rF+trZbB9GvKF_=2Rv2g1w@mail.gmail.com>
Subject: Re: [PATCH] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     benh@kernel.crashing.org, paulus@samba.org, tglx@linutronix.de,
        linuxppc-dev@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Apr 5, 2020 at 6:13 PM Christophe Leroy <christophe.leroy@c-s.fr> w=
rote:
>
>
>
> Le 05/04/2020 =C3=A0 09:51, Qiujun Huang a =C3=A9crit :
> > Here needs a NULL check.
> >
> > Issue found by coccinelle.
> >
> > Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> > ---
> >   arch/powerpc/platforms/powernv/opal.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platf=
orms/powernv/opal.c
> > index 2b3dfd0b6cdd..09443ae3a86e 100644
> > --- a/arch/powerpc/platforms/powernv/opal.c
> > +++ b/arch/powerpc/platforms/powernv/opal.c
> > @@ -811,6 +811,11 @@ static int opal_add_one_export(struct kobject *par=
ent, const char *export_name,
> >               goto out;
> >
> >       attr =3D kzalloc(sizeof(*attr), GFP_KERNEL);
> > +     if (!attr) {
> > +             rc =3D -ENOMEM;
> > +             goto out;
>
> You don't need to go to out:, there is nothing to do. You should do:
>
>         if (!attr)
>                 return -ENOMEM;

Yeah, I get that. Thanks.

>
> > +     }
> > +
> >       name =3D kstrdup(export_name, GFP_KERNEL);
> >       if (!name) {
> >               rc =3D -ENOMEM;
> >
>
> Christophe