Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200405104913.22806-1-peron.clem@gmail.com> <20200405104913.22806-4-peron.clem@gmail.com>
 <20200405112409.gl6kn7cjakwludf6@core.my.home>
In-Reply-To: <20200405112409.gl6kn7cjakwludf6@core.my.home>
From:   =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Date:   Sun, 5 Apr 2020 16:35:19 +0200
Message-ID: <CAJiuCceZ=MGWqv4LF9CJpJyGmgq+uTirxXAFoACiqt0Mz76A-g@mail.gmail.com>
Subject: Re: [linux-sunxi] [PATCH 3/7] arm64: dts: allwinner: h6: set thermal
 polling time
To:     =?UTF-8?Q?Ond=C5=99ej_Jirman?= <megous@megous.com>,
        =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ond=C5=99ej,

On Sun, 5 Apr 2020 at 13:24, Ond=C5=99ej Jirman <megous@megous.com> wrote:
>
> Hello,
>
> On Sun, Apr 05, 2020 at 12:49:09PM +0200, Cl=C3=A9ment P=C3=A9ron wrote:
> > Add reasonable thermal polling time for Allwinner H6.
> >
> > Signed-off-by: Cl=C3=A9ment P=C3=A9ron <peron.clem@gmail.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/=
boot/dts/allwinner/sun50i-h6.dtsi
> > index d4d3963705f5..c3e4f09f60ce 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > @@ -905,8 +905,8 @@
> >
> >       thermal-zones {
> >               cpu-thermal {
> > -                     polling-delay-passive =3D <0>;
> > -                     polling-delay =3D <0>;
> > +                     polling-delay-passive =3D <100>;
> > +                     polling-delay =3D <1000>;
> >                       thermal-sensors =3D <&ths 0>;
>
> This is not necessary, and will not do anything useful, since the driver
> uses interrupts to update the thermal zone's temperature. Please keep the
> values at 0.
>
> With your settings the thermal zone would just add a polling timer in add=
ition
> to being updated every 250ms via THS interrupt. The real thermal measurem=
ents
> are available every 250ms anyway, so setting a smaller period here will n=
ot do
> anything useful, and 1s period will not lead to slower updates either.
>
> Values of 0 mean tell the thermal zone to rely on thermal driver to updat=
e
> the thermal zone by itself (via interrupt) and to not poll.

Thanks for the explanations,
I will drop this patch.

Regards,
Cl=C3=A9ment
>
> regards,
>         o.
>
> >                       trips {
> > @@ -935,8 +935,8 @@
> >               };
> >
> >               gpu-thermal {
> > -                     polling-delay-passive =3D <0>;
> > -                     polling-delay =3D <0>;
> > +                     polling-delay-passive =3D <100>;
> > +                     polling-delay =3D <1000>;
> >                       thermal-sensors =3D <&ths 1>;
> >               };
> >       };
> > --
> > 2.20.1
> >
> > --
> > You received this message because you are subscribed to the Google Grou=
ps "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send =
an email to linux-sunxi+unsubscribe@googlegroups.com.
> > To view this discussion on the web, visit https://groups.google.com/d/m=
sgid/linux-sunxi/20200405104913.22806-4-peron.clem%40gmail.com.