Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200405104913.22806-1-peron.clem@gmail.com> <20200405115138.vrrvv7spnv6ifm6x@core.my.home>
 <CAJiuCcfAKCs5ZLi_O21eyx-ZraC2Sb_ugQSmOEYm5+eVkQ7ZSw@mail.gmail.com> <20200405145443.uycsh73kxmurdmil@core.my.home>
In-Reply-To: <20200405145443.uycsh73kxmurdmil@core.my.home>
From:   =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Date:   Sun, 5 Apr 2020 17:01:51 +0200
Message-ID: <CAJiuCceROWv1ni3YZ6rU71O9R__t6ZOgnkZQDjBhJvhqHRAVng@mail.gmail.com>
Subject: Re: [linux-sunxi] [PATCH 0/7] Add support for Allwinner H6 DVFS
To:     =?UTF-8?Q?Ond=C5=99ej_Jirman?= <megous@megous.com>,
        =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Sun, 5 Apr 2020 at 16:54, Ond=C5=99ej Jirman <megous@megous.com> wrote:
>
> Hi,
>
> On Sun, Apr 05, 2020 at 04:33:37PM +0200, Cl=C3=A9ment P=C3=A9ron wrote:
> > Hi Ond=C5=99ej,
>
> [ ... ]
>
> > Good point, this information should be added for both CPU and GPU regul=
ator.
> > This could be nice to confirm this point with a scope.
> >
> > Also I remark that Allwinner user higher temperature than what we set :
> > alarm_low_temp =3D <105000>;
> > alarm_high_temp =3D <110000>;
> > alarm_temp_hysteresis =3D <15000>;
> > shut_temp=3D <115000>;
> > https://github.com/orangepi-xunlong/OrangePiH6_Linux4_9/blob/master/arc=
h/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L1924
> >
> > Don't you think that we can push a bit higher the temperature it's
> > actually at 80=C2=B0C ?
>
> We probably can. But just 5=C2=B0C between high temp and criticla temp is=
 probably
> not enough. I'd probably set our value to something like 90-100=C2=B0C so=
 that quick
> temperature spike before regulation kicks in would not shutdown the CPU.

OK I will push it to 85=C2=B0C and leave the critical to 100=C2=B0C.

Test it again and will send a v2

Regards,
Cl=C3=A9ment

>
> regards,
>         o.
>
> > Thanks for the review,
> > Clement
> >