Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2553502ybb; Sun, 5 Apr 2020 10:22:07 -0700 (PDT) X-Google-Smtp-Source: APiQypJq4dqdl4hBCEqHRCow4I9slH91i4K0pSvKRNxq18RujJNp/4FzRlOMiCCLa80TSM6I5g1M X-Received: by 2002:a9d:7590:: with SMTP id s16mr14423932otk.250.1586107327816; Sun, 05 Apr 2020 10:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586107327; cv=none; d=google.com; s=arc-20160816; b=pp7kwBIvofjQDves8TbzYGb7rrlHESHsiGf7ZW/Am9OdNwDhnKCLkEwMIUgBbdYN5Z aSRNdzBcNamTZlalthPevxs/oZcPPRbgjAMbH18DMugzTgX2V3/Nfyv7frfwlcWGbLxG TNw8LcygpF3yi8LuzfCWJ2OfjJsbGj5l5lPNqtqseygG670KDW13indq4Szbo8H+3v7Z xrbC1/x4/yWvBzevLZDj3pPWGW+UXiXD6f0xt2yem7mL88w2OV/Bx9iI8toACfx2Tjgv 1vMwPncodZjtMgzvuYCfPAHNRLWkBQcBAHNsWfzcRpiG7PWNSuMUPRYRdNTarAOBkVlC J0Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=ULxU9OQbABALQfrntGVvXtudgxD5xGwtih1+Wnbr480=; b=DX7dcAWBcnelZXHSTHPI40RuysoObnB5Fd8yknra6EXXdq7M4BC9TWvHT8D3HYaP/c W7l8B/uBhvAAn6iqFti/rjts82WpiXX9uQTCnkM/4ZHrf7Lca+HIDXL2qD/t4PmBagNq K9DCJeFT5qFW5f5aq+vRxSSA887A6/WI6cCzRqulxB6/xIk7RO+fgxpia7WFz3Koh3HO QxkqE0C68RDSo1BgmlWoiYtHf0UWUUQWSPwcNTnShOjiFzvTVrn/o+HCV/V2JhU/endR 8cVK6FSiRCt43doIf72QdDrL/7B1BJcSfW/wtjVv3RPf2PsrRqx/rSPjzCJMuSRcNgdy HGBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si3660924otg.145.2020.04.05.10.21.55; Sun, 05 Apr 2020 10:22:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbgDERQz (ORCPT + 99 others); Sun, 5 Apr 2020 13:16:55 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:47792 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726771AbgDERQy (ORCPT ); Sun, 5 Apr 2020 13:16:54 -0400 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S23991372AbgDERQvZEzH1 (ORCPT + 2 others); Sun, 5 Apr 2020 19:16:51 +0200 Date: Sun, 5 Apr 2020 18:16:51 +0100 (BST) From: "Maciej W. Rozycki" To: Masahiro Yamada cc: linux-kbuild@vger.kernel.org, linux-mips@linux-mips.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Jiaxun Yang , Paul Burton , Thomas Bogendoerfer , linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: fw: arc: add __weak to prom_meminit and prom_free_prom_memory In-Reply-To: <20200405163052.18942-1-masahiroy@kernel.org> Message-ID: References: <20200405163052.18942-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Apr 2020, Masahiro Yamada wrote: > As far as I understood, prom_meminit() in arch/mips/fw/arc/memory.c > is overridden by the one in arch/mips/sgi-ip32/ip32-memory.c if > CONFIG_SGI_IP32 is enabled. > > The use of EXPORT_SYMBOL in static libraries potentially causes a > problem for the llvm linker [1]. So, I want to forcibly link lib-y > objects to vmlinux when CONFIG_MODULES=y. It looks to me like a bug in the linker in the handling of the EXTERN command. Why not fix the linker instead? Maciej