Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2555259ybb; Sun, 5 Apr 2020 10:24:44 -0700 (PDT) X-Google-Smtp-Source: APiQypI+6lqfLRIbC/Jzpau7i08SlvR/61ddx8XlPW4vlRHhQckdkA3nf2KbK7tlltuVdLUWHgmg X-Received: by 2002:a9d:7f19:: with SMTP id j25mr14821629otq.129.1586107484039; Sun, 05 Apr 2020 10:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586107484; cv=none; d=google.com; s=arc-20160816; b=N4qvwYGGKYnEZ0cxYVF4PzUDLBenc7NmfKrln+U5EnYXszOLdb8ygSbUdGdF0PHiwx c2WMrjPJWJxSjFG9TvJZNBpd94h1HuezPsHJA1hHMs6nvjPokE5JqD8ER1vfbuED4+4J ROoNg6n/NFU6zgLofrVxMUkLxFxBSCdI/ikV0kMNS/WpCf4cE7rJm46001LWYbbKojww gEvRGwLmL3Lr8NonP5UogGdqhpRg691/K7A0AFjeE52mju1Mq1VISIOGkp/f16Wi0bdj T2o07b0U4/YmVMDe0eI8Sbs9XpvahDR63+ygYF49Vgpx2jnd1C+WuBGFTjt4wpg29pqV +WGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:date:from:dkim-signature; bh=yPEjuWyQ9aW5UfsWY/0pffS6lX/UZzplajlsr7ydC3s=; b=VodBRvS801p86kwXzPi5Wu3DBWYp10hwfO1UkSII58GkvWqKkTpTvDDrnzyObBh7i3 XTife+209PSX1VNkDB9gP5MOGLNMyXK8TFWN32x18ziVxzMVKWXcyNfJ85Ke0lyCOzEn RanfmXWrRfLVonpW+0u7cUbC9xNrXDnuabcLsDTturoU+hjvLCW4CZLxft9qaUhfkpPF de4qsSaA5IHSxss8zeOpwZTN9gtRNamvk586Lg7ft5fmepkux72uAWKRJ2Pl11yICZcc vqeVufCL+kgTmEIHjZZKNhj4GvCNzLBaa3R0ZU1+WxgDVQiA4g5LTmcEjbGQY9pERWHu 571g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=naJ+eFJh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si6880518otp.268.2020.04.05.10.24.31; Sun, 05 Apr 2020 10:24:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=naJ+eFJh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgDERXc (ORCPT + 99 others); Sun, 5 Apr 2020 13:23:32 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:35067 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbgDERXb (ORCPT ); Sun, 5 Apr 2020 13:23:31 -0400 Received: by mail-lj1-f193.google.com with SMTP id k21so12192576ljh.2 for ; Sun, 05 Apr 2020 10:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yPEjuWyQ9aW5UfsWY/0pffS6lX/UZzplajlsr7ydC3s=; b=naJ+eFJhwX0b3neaEjeSBsB2hvbtuO2W56Cvko0OKp8VaOUx3T/gqXLSofntRMaMuJ X0k0OsxuPeUGM0DoqLwLLvTgs+7mSNF5fYJKWWWZEZtgjjpJxDXijV0Rvew8rawq7BDx kMDbQOMquRDvD535LSe6/pxWICoQbZPWQOa2z/d98zvon8i0JWDbGakkwP61bY/MRBQh zpgM/W7Tx/4+lfFuTxVeExRKAbjJs75is68ec4R5m41Nssh3SnSCimCRb4VEqlpTHTBx GDQrc97Axh/lNy34j/YOdsi1yU9h+7jbqqSt5ci7JzgBfTM0Zr+siA3ZYr1m58XuEqiZ UKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yPEjuWyQ9aW5UfsWY/0pffS6lX/UZzplajlsr7ydC3s=; b=CzjxMvuyoM4mQKycXyS7QmMtCmLa2MeFsikZJZhtCfDOumGtnC2yZbKXStQQ7b4TgM +BRH1l+Bwcnqa8rNXj7M8OySuseSmCCRg/xzpSE8iFoDjPSJN1cjWYhAVpNr3GvxKYw/ thiBaViei7onszs+7aVV7SV9kwN8R+MAiXh94/bvC5HZxkaxyTeB/Ck1l6Dj4gpwKYR/ aeWY17qXncJ1FtunKHmTGEHqWBS79qzvQp430k/B/aB7ABRatYVS38tCGQG0fDvtuuyj Lhs86x4TZNlH3u8jhVNNIjxsnGbpb7SwDCdiHvajQ4QjVJyflrtLKDRIcfuOBftnt9Wg gQig== X-Gm-Message-State: AGi0PubbY6Jm4XaTPLrNAJlPTgvUDd1PLK8WgAlmkCs7Hyo1Whk0DH+o RngNqYi+O2/sJCIjlrqcMzk= X-Received: by 2002:a2e:8719:: with SMTP id m25mr10222447lji.76.1586107410011; Sun, 05 Apr 2020 10:23:30 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id k4sm9954742lfo.47.2020.04.05.10.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2020 10:23:29 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sun, 5 Apr 2020 19:23:15 +0200 To: William Kucharski Cc: Uladzislau Rezki , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, jroedel@suse.de, vbabka@suse.cz, Thomas Gleixner Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-ID: <20200405172315.GA8404@pc636> References: <20200404185229.GA424@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 04, 2020 at 11:25:45PM -0600, William Kucharski wrote: > > > > On Apr 4, 2020, at 12:52 PM, Uladzislau Rezki wrote: > > > >> > >> Is there any need to similarly sanitize “size” to assure start + size doesn’t go past “end?” > >> > > Why is that double check needed if all such tests are done deeper on stack? > > If such tests ARE performed, then it doesn't matter to me whether it is checked before or after, > it just seems that nothing checks whether start + size makes some sort of sense with respect > to end. > > I admit I didn't walk through all the routines to see if such a check would be superfluous. > Yes, we check it: static __always_inline bool is_within_this_va(struct vmap_area *va, unsigned long size, unsigned long align, unsigned long vstart) { ... return (nva_start_addr + size <= va->va_end); } -- Vlad Rezki