Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2836465ybb; Sun, 5 Apr 2020 18:20:30 -0700 (PDT) X-Google-Smtp-Source: APiQypKTa/gDQTsOBQvTNMLV5BtqKwspLX3OTcsy9+fJNl+hbbc1eqBx6Pjy6d50rt5jdo+wFS5i X-Received: by 2002:aca:3049:: with SMTP id w70mr9016127oiw.146.1586136030343; Sun, 05 Apr 2020 18:20:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586136030; cv=none; d=google.com; s=arc-20160816; b=up59SRUDlsH9owL3qq5NHzRpRFPS059+R0PPOgAwOIosgeUYUubN2vhBBhPCBnRSYg roPMcfzRvISd6Tn93fU1Za9Ca97p/bq8aOX2wSJXTbV4RZsiW8DUOuU2hnC7UDJP4GLW JBpTDSlQ06zM7ymT1xdEvOcw5e7BQl9vg2CIPQ6tCy64qptmwKsc45Fn/afmZWubbwhz //En8iboh5VYycJPlwTgGVswvInl0Ck7DZwfDyMfStYn/7MIiDmJ8Idgrf4noz4ZQK/q lRmJM8CclL/YT4+RTXPuQ5/ez8ucL24OpQCjMrLs+bq9GEbifsM0IM/vBunGnOJrezIx VBQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IbprTDW1u1HJSZmzEjh4jO7mD74iEgUk0lP0fkv1P5U=; b=A45ioTnYqcwxumJnJ+y5IRE/R30FMaMoYZ+O7baQkm8XnXslJHJg52vgRK6/ZpPHt/ ejBVGTrRvtT4B4ZPANjp7iCj3Sao4a0U1AykVOJp6S8dyBIJFkhRPEDq6Wdnpi6yLoLw 7Yb26VST4rvO2h9Q1CNXOkMJPjU7X6pun9Kvp5qMjFIMSkGlo+jFDwQbXai4TSZyVvTK Ax7gZw8Hq9MXG/Nf6/FOo0qzcnGw/aa6ytlJQ02NNn3zDpghM9x8g/sAuAlRCPkk8lZp k8v7wYL2bsP8M7Fkvh6Pyq+lxlImA0AQDP4IjxdgIAY0UKnKmTM1S+/lJDitIyGqcujj 3w1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GkHHIbyO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x14si6771911ooq.78.2020.04.05.18.20.17; Sun, 05 Apr 2020 18:20:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GkHHIbyO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727939AbgDFBPG (ORCPT + 99 others); Sun, 5 Apr 2020 21:15:06 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:34182 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgDFBPG (ORCPT ); Sun, 5 Apr 2020 21:15:06 -0400 Received: by mail-il1-f194.google.com with SMTP id t11so13154972ils.1; Sun, 05 Apr 2020 18:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IbprTDW1u1HJSZmzEjh4jO7mD74iEgUk0lP0fkv1P5U=; b=GkHHIbyOBZRFRpN+beehXEmD1sX8a7TvGoNIJPqJz4BdB4IxJwMEqZNFt9lt95Lewc k+kP9/qc/H0akb0VM1N/pFTzJKtGebCHlxGPab+9fUPwdJvzppoM5MD0BNdxER2KONJS Ps7ZsmbYXpeaf1qVmQ2b8ekmdbTzyuTTeUdQom+Nvup2XVthSRbyduMQeu1D50/mRkNo 2YfVErRZ/7MIPh8OmQIroRxNG9Fb51uDv5ThBw43Uz7huaG0zRLbtnQOo2Xvt4yIZiOH r8NR59/akimA+OXb+cO8cHFTn4rT4Ew9CEIvsDqDbJFfuaLL1rxYWSRF/Ok6F28H+Kti JABg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IbprTDW1u1HJSZmzEjh4jO7mD74iEgUk0lP0fkv1P5U=; b=CqN1I6ggk8NqTC7ZhmTRPwLYSE9D7b/orKgWCeoJPsOM/qG+nMwnoxWT4IBJ/PeXug r+6OyqBIjdhGqAFrfp9kqZceJZI9sZBOotD0EuuUxNOWsm0qgKpKn1OOSuO1+iLSjaeM 0TXFPJ6qC6NEcvranOtDhCCPBUeH0418imGJOB6BQNL/hEh5k6oSvfnV52602TrazYQl NnSsUVe+6UNgzag94wgV5dbjilRqycEmPf0voNHn46rW3tdERvcSZXcUeatDJYXa6Mo7 U8DCx2eHsIv3CkQISelI9ZPbPJUlOFRgTy1dJ7SP6l+owB3GlE6nZR09dzVxWxdM8tEF MlsA== X-Gm-Message-State: AGi0PuZqdgLZ14g/10LLPNICw5z3BpTQ9BMFw6oLx4ZNi30cdk6/cEm1 RWrVO1bVhmllYdj/j2a2bHTzEDtN3MMs9YVM/0k= X-Received: by 2002:a92:5b56:: with SMTP id p83mr19231598ilb.70.1586135705788; Sun, 05 Apr 2020 18:15:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Qiujun Huang Date: Mon, 6 Apr 2020 09:14:52 +0800 Message-ID: Subject: Re: [PATCH] KVM: PPC: Book3S HV: Remove NULL check before kfree To: Markus Elfring Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, LKML , Benjamin Herrenschmidt , Chen Zhou , Michael Ellerman , Paul Mackerras Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry about noise, please just ignore it. On Mon, Apr 6, 2020 at 4:50 AM Markus Elfring wrote: > > > NULL check before kfree is unnecessary, so remove it. > > Would you like to take similar update suggestions into account? > * 2019-09-04 > KVM: PPC: Book3S HV: Delete an unnecessary check before kfree() in __kvmhv_nested_page_fault() > > * [-next] KVM: PPC: Book3S HV: remove redundant NULL check > https://lkml.kernel.org/lkml/20200401130903.6576-1-chenzhou10@huawei.com/ > https://lore.kernel.org/patchwork/patch/1218800/ > > Regards, > Markus