Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 net] skbuff.h: Improve the checksum related comments
To:     decui@microsoft.com, willy@infradead.org, netdev@vger.kernel.org,
        davem@davemloft.net, willemb@google.com, kuba@kernel.org,
        simon.horman@netronome.com, sdf@google.com, edumazet@google.com,
        fw@strlen.de, jonathan.lemon@gmail.com, pablo@netfilter.org,
        jeremy@azazel.net, pabeni@redhat.com
Cc:     linux-kernel@vger.kernel.org
References: <1586136369-67251-1-git-send-email-decui@microsoft.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <6efee6bb-d68d-0f83-d469-b173cf4f5d0f@infradead.org>
Date:   Sun, 5 Apr 2020 18:42:33 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <1586136369-67251-1-git-send-email-decui@microsoft.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/5/20 6:26 PM, Dexuan Cui wrote:
> @@ -211,9 +211,9 @@
>   * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the
>   * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload as
>   * part of the GSO operation is implied. If a checksum is being offloaded
> - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and csum_offset
> - * are set to refer to the outermost checksum being offload (two offloaded
> - * checksums are possible with UDP encapsulation).
> + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start and
> + * csum_offset are set to refer to the outermost checksum being offload (two

                                                             being offloaded

> + * offloaded checksums are possible with UDP encapsulation).
>   */
>  
>  /* Don't change this without changing skb_csum_unnecessary! */


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.
-- 
~Randy