Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2943219ybb; Sun, 5 Apr 2020 21:35:18 -0700 (PDT) X-Google-Smtp-Source: APiQypIP61l+z2CDKusmHydJHP32FW+zKC0EfLGsvr57bWHC3IKd+2xmK25Fxl1RppHxCSDbzFAy X-Received: by 2002:aca:ecd0:: with SMTP id k199mr11942468oih.60.1586147718332; Sun, 05 Apr 2020 21:35:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586147718; cv=none; d=google.com; s=arc-20160816; b=tqYG1Z8BWvSEm5zkj4sJ3chJV0+VPiQbjyd/efA/WZQDhIubTe/5uaL9INM10+9vCW vggu1d0arJEMX7B/ga3mLY+EhMxJFEa+FV11oklsK+S8ltkbJEbnqtQx9uLPlx7BDLm4 5znvram5PmdfxxqBezg6PKA1QxRubEsYb+MNrYgVuQp1uFwAbi97FxY3pAZek7UDIcFn BA7PNmewSDEZRVWn9WKxsfNeKMFwsabc/yE2A/91nPTXi1FcYgsYiTbfNjdxAbzYVQWs cKIf0/PNhMOBr01HRUj6IB02bklSo+PFecI4QLM/JNJrbTOuENgFjR12SQe05tl/UReD tmfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kI3CZf+AqJTEneVmmyQsRJ0cjVOZXvHQLlNqte8FSXI=; b=j+lhav/N5+RLbrWZLNWuEeRvTLBXrzJpsjShRhJmNYwC0VNTJUxHpj1VIorwDfmZzA Qm0xZH5+JKrXD6gsoVuavJQGRJZiGsi+NNGGbktUWM0RrKyaUHnayEWNhaTD4dQa+snX ZnizogEwyMN8Fetv46Bt6/Wbrj0L9huse8rF34ujWoHjXKrzTKqYJLF9k6BpDS3wJzmm JXCxRGhXplZNVP6Yr0kjS7bCVHhGiLjEGbyuep67jo/FJIB3lp+84tQzXTVN+X//3y3f 8vHG9vxEy2bWiRczpov85L9X1yDb9P6mWsLw8O5tkMv60cwPYBagmv2vmxq76437ty8/ 0Zdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si7531321otq.296.2020.04.05.21.35.05; Sun, 05 Apr 2020 21:35:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgDFEdb (ORCPT + 99 others); Mon, 6 Apr 2020 00:33:31 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:3991 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbgDFEda (ORCPT ); Mon, 6 Apr 2020 00:33:30 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee55e8ab0fd965-9aa61; Mon, 06 Apr 2020 12:33:03 +0800 (CST) X-RM-TRANSID: 2ee55e8ab0fd965-9aa61 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.1.173.122]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee55e8ab0fb2ea-b5e8c; Mon, 06 Apr 2020 12:33:03 +0800 (CST) X-RM-TRANSID: 2ee55e8ab0fb2ea-b5e8c From: Tang Bin To: minyard@acm.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH v2]ipmi:bt-bmc:Avoid unnecessary judgement Date: Mon, 6 Apr 2020 12:34:15 +0800 Message-Id: <20200406043415.12292-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In this driver,only the platform_device and platform_driver matches,can trigger bt_bmc_probe(),and the trigger mode is just Device Tree.Thus remove redundant judgments. Signed-off-by: Tang Bin --- Changes from v1: - improve the commit message. drivers/char/ipmi/bt-bmc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index d36aeacb2..890ad55aa 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -430,9 +430,6 @@ static int bt_bmc_probe(struct platform_device *pdev) struct device *dev; int rc; - if (!pdev || !pdev->dev.of_node) - return -ENODEV; - dev = &pdev->dev; dev_info(dev, "Found bt bmc device\n"); -- 2.20.1.windows.1