Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751199AbWBZFPc (ORCPT ); Sun, 26 Feb 2006 00:15:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751204AbWBZFPc (ORCPT ); Sun, 26 Feb 2006 00:15:32 -0500 Received: from stat9.steeleye.com ([209.192.50.41]:33490 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1751199AbWBZFPb (ORCPT ); Sun, 26 Feb 2006 00:15:31 -0500 Subject: Re: [stable] [PATCH 1/2] sd: fix memory corruption by sd_read_cache_type From: James Bottomley To: Linus Torvalds Cc: Stefan Richter , Chris Wright , stable@kernel.org, Jody McIntyre , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Al Viro In-Reply-To: References: <20060225021009.GV3883@sorel.sous-sol.org> <4400E34B.1000400@s5r6.in-berlin.de> Content-Type: text/plain Date: Sat, 25 Feb 2006 23:14:48 -0600 Message-Id: <1140930888.3279.4.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 24 On Sat, 2006-02-25 at 16:01 -0800, Linus Torvalds wrote: > Perhaps equally importantly, let's get them into mainline if they are so > important. Which means that I want sign-offs and acks from the appropriate > people (scsi and original author, which is apparently Al). Yes, I've been thinking about this. The problem is that it's a change to sd and a change to scsi_lib in a fairly critical routine. While I'm reasonably certain the change is safe, I'd prefer to make sure by incubating in -mm for a while. The title, by the way, is misleading; it's not a memory corruption in sd at all really. It's the initio bridge which produces a totally standards non conformant return to a mode sense which produces the problem. And so, it's only the single initio bridge which is currently affected; hence the caution. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/