Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200401174937.3969599-1-bmasney@redhat.com>
In-Reply-To: <20200401174937.3969599-1-bmasney@redhat.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 6 Apr 2020 09:16:50 +0200
Message-ID: <CAMpxmJVzUPcRe=8MoHdsq_LNdZVT5rvPjF+38BmRTGU_zh-6LA@mail.gmail.com>
Subject: Re: [PATCH] drivers: gpio: xgene-sb: set valid IRQ type in to_irq()
To:     Brian Masney <bmasney@redhat.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, dhoward@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 1 kwi 2020 o 19:49 Brian Masney <bmasney@redhat.com> napisa=C5=82=
(a):
>
> xgene-sb is setup to be a hierarchical IRQ chip with the GIC as the
> parent chip. xgene_gpio_sb_to_irq() currently sets the default IRQ type
> to IRQ_TYPE_NONE, which the GIC loudly complains about with a WARN_ON().
> Let's set the initial default to a sane value (IRQ_TYPE_EDGE_RISING)
> that was determined by decoding the ACPI tables on affected hardware:
>
>     Device (_SB.GPSB)
>     {
>         Name (_HID, "APMC0D15")  // _HID: Hardware ID
>         Name (_CID, "APMC0D15")  // _CID: Compatible ID
>         Name (_UID, "GPIOSB")  // _UID: Unique ID
>         ...
>         Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settin=
gs
>         {
>             ...
>             Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, ,, =
)
>             {
>                 0x00000048,
>             }
>             ...
>         }
>     }
>
> This can be overridden later as needed with irq_set_irq_type().
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  drivers/gpio/gpio-xgene-sb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c
> index 25d86441666e..b45bfa9baa26 100644
> --- a/drivers/gpio/gpio-xgene-sb.c
> +++ b/drivers/gpio/gpio-xgene-sb.c
> @@ -122,7 +122,7 @@ static int xgene_gpio_sb_to_irq(struct gpio_chip *gc,=
 u32 gpio)
>         fwspec.fwnode =3D gc->parent->fwnode;
>         fwspec.param_count =3D 2;
>         fwspec.param[0] =3D GPIO_TO_HWIRQ(priv, gpio);
> -       fwspec.param[1] =3D IRQ_TYPE_NONE;
> +       fwspec.param[1] =3D IRQ_TYPE_EDGE_RISING;
>         return irq_create_fwspec_mapping(&fwspec);
>  }
>
> --
> 2.25.1
>

Patch applied, thanks!

Bartosz