Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20200302062625epcas1p200c53fabe17996e92257a409b7a9c857@epcas1p2.samsung.com>
 <20200302062145.1719-1-namjae.jeon@samsung.com> <20200302062145.1719-12-namjae.jeon@samsung.com>
In-Reply-To: <20200302062145.1719-12-namjae.jeon@samsung.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 6 Apr 2020 09:27:01 +0200
Message-ID: <CAMuHMdXdGDnvGYi1v1OhjCz=61moVRZQdZOtiKLG3m8q7vwkTg@mail.gmail.com>
Subject: Re: [PATCH v14 11/14] exfat: add Kconfig and Makefile
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Valdis Kletnieks <valdis.kletnieks@vt.edu>,
        Christoph Hellwig <hch@lst.de>, sj1557.seo@samsung.com,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, linkinjeon@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Namjae,

On Mon, Mar 2, 2020 at 7:28 AM Namjae Jeon <namjae.jeon@samsung.com> wrote:
> This adds the Kconfig and Makefile for exfat.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

This is now commit b9d1e2e6265f5dc2 ("exfat: add Kconfig and Makefile").

> --- /dev/null
> +++ b/fs/exfat/Kconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +config EXFAT_FS
> +       tristate "exFAT filesystem support"
> +       select NLS
> +       help
> +         This allows you to mount devices formatted with the exFAT file system.
> +         exFAT is typically used on SD-Cards or USB sticks.
> +
> +         To compile this as a module, choose M here: the module will be called
> +         exfat.
> +
> +config EXFAT_DEFAULT_IOCHARSET
> +       string "Default iocharset for exFAT"
> +       default "utf8"
> +       depends on EXFAT_FS
> +       help
> +         Set this to the default input/output character set to use for
> +         converting between the encoding is used for user visible filename and
> +         UTF-16 character that exfat filesystem use, and can be overridden with

exFAT

> +         the "iocharset" mount option for exFAT filesystems.

I think the above paragraph should be reworded.
I tried to do it myself:

          Set this to the default input/output character set to use for
          converting between the encoding that is used for user visible
          filenames, and the UTF-16 character set that the exFAT filesystem
          uses.  This can be overridden with the "iocharset" mount option for
          the exFAT filesystems.

but then I got puzzled by the _3_ encodings that are part of it:
  1. the default input/output character set to use for conversion,
  2. encoding that is used for user visible filenames,
  3. UTF-16 character set that the exFAT filesystem uses.
I assume 1 == 2, but there may be more to it?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds