Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] sched/arm64: store cpu topology before
 notify_cpu_starting
To:     Valentin Schneider <valentin.schneider@arm.com>
CC:     <vpillai@digitalocean.com>, <aaron.lwe@gmail.com>,
        <aubrey.intel@gmail.com>, <aubrey.li@linux.intel.com>,
        <fweisbec@gmail.com>, <jdesfossez@digitalocean.com>,
        <joel@joelfernandes.org>, <joelaf@google.com>,
        <keescook@chromium.org>, <kerrnel@google.com>,
        <linux-kernel@vger.kernel.org>, <mgorman@techsingularity.net>,
        <mingo@kernel.org>, <naravamudan@digitalocean.com>,
        <pauld@redhat.com>, <pawan.kumar.gupta@linux.intel.com>,
        <pbonzini@redhat.com>, <peterz@infradead.org>, <pjt@google.com>,
        <tglx@linutronix.de>, <tim.c.chen@linux.intel.com>,
        <torvalds@linux-foundation.org>, <xiexiuqi@huawei.com>,
        <huawei.libin@huawei.com>, <w.f@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "chengjian (D)" <cj.chengjian@huawei.com>
References: <855831b59e1b3774b11c3e33050eac4cc4639f06.1583332765.git.vpillai@digitalocean.com>
 <20200401114215.36640-1-cj.chengjian@huawei.com> <jhjwo6zjq5m.mognet@arm.com>
From:   "chengjian (D)" <cj.chengjian@huawei.com>
Message-ID: <9686e37d-5698-334d-5e23-70a1e2d804ec@huawei.com>
Date:   Mon, 6 Apr 2020 16:00:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <jhjwo6zjq5m.mognet@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/4/1 21:23, Valentin Schneider wrote:
> (+LAKML, +Sudeep)
>
> On Wed, Apr 01 2020, Cheng Jian wrote:
>> when SCHED_CORE enabled, sched_cpu_starting() uses thread_sibling as
>> SMT_MASK to initialize rq->core, but only after store_cpu_topology(),
>> the thread_sibling is ready for use.
>>
>>        notify_cpu_starting()
>>            -> sched_cpu_starting()	# use thread_sibling
>>
>>        store_cpu_topology(cpu)
>>            -> update_siblings_masks	# set thread_sibling
>>
>> Fix this by doing notify_cpu_starting later, just like x86 do.
>>
> I haven't been following the sched core stuff closely; can't this
> rq->core assignment be done in sched_cpu_activate() instead? We already
> look at the cpu_smt_mask() in there, and it is valid (we go through the
> entirety of secondary_start_kernel() before getting anywhere near
> CPUHP_AP_ACTIVE).
>
> I don't think this breaks anything, but without this dependency in
> sched_cpu_starting() then there isn't really a reason for this move.

Yes, it is correct to put the rq-> core assignment in sched_cpu_active().

The cpu_smt_mask is already valid here.


I have made such an attempt on my own branch and passed the test.


Thank you.


     -- Cheng Jian